Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile

2018-09-05 Thread Masahiro Yamada
2018-09-06 7:53 GMT+09:00 Segher Boessenkool : > On Mon, Sep 03, 2018 at 12:00:21PM +0200, Borislav Petkov wrote: >> On Mon, Sep 03, 2018 at 06:54:12PM +0900, Masahiro Yamada wrote: >> > You are right - I missed this usecase, >> > but I still want to excuse "it is rare enough". >> >> Isn't there a

Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile

2018-09-05 Thread Segher Boessenkool
On Mon, Sep 03, 2018 at 12:00:21PM +0200, Borislav Petkov wrote: > On Mon, Sep 03, 2018 at 06:54:12PM +0900, Masahiro Yamada wrote: > > You are right - I missed this usecase, > > but I still want to excuse "it is rare enough". > > Isn't there a Makefile way to check file existence before including

Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile

2018-09-03 Thread Borislav Petkov
On Mon, Sep 03, 2018 at 06:54:12PM +0900, Masahiro Yamada wrote: > You are right - I missed this usecase, > but I still want to excuse "it is rare enough". Isn't there a Makefile way to check file existence before including it? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid

Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile

2018-09-03 Thread Masahiro Yamada
Hi, 2018-09-03 18:39 GMT+09:00 Borislav Petkov : > Hey, > > On Fri, Jul 20, 2018 at 04:46:32PM +0900, Masahiro Yamada wrote: >> When you build targets that require the kernel configuration, dot-config >> is set to 1, then the top-level Makefile includes auto.conf. However, >> Make considers its i

Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile

2018-09-03 Thread Borislav Petkov
Hey, On Fri, Jul 20, 2018 at 04:46:32PM +0900, Masahiro Yamada wrote: > When you build targets that require the kernel configuration, dot-config > is set to 1, then the top-level Makefile includes auto.conf. However, > Make considers its inclusion is optional because the '-include' directive > is

[PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile

2018-07-20 Thread Masahiro Yamada
When you build targets that require the kernel configuration, dot-config is set to 1, then the top-level Makefile includes auto.conf. However, Make considers its inclusion is optional because the '-include' directive is used here. If a necessary configuration file is missing for the external modu