Re: [PATCH v4 07/31] kconfig: add built-in function support

On Tue, May 22, 2018 at 6:50 AM, Ulf Magnusson wrote: > On Tue, May 22, 2018 at 5:11 AM, Masahiro Yamada > wrote: >> 2018-05-22 0:10 GMT+09:00 Ulf Magnusson : >>> On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Tue, May 22, 2018 at 6:50 AM, Ulf Magnusson wrote: > On Tue, May 22, 2018 at 5:11 AM, Masahiro Yamada > wrote: >> 2018-05-22 0:10 GMT+09:00 Ulf Magnusson : >>> On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson wrote: On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson wrote: > On Sun, May

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Tue, May 22, 2018 at 5:11 AM, Masahiro Yamada wrote: > 2018-05-22 0:10 GMT+09:00 Ulf Magnusson : >> On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson wrote: >>> On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Tue, May 22, 2018 at 5:11 AM, Masahiro Yamada wrote: > 2018-05-22 0:10 GMT+09:00 Ulf Magnusson : >> On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson wrote: >>> On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson wrote: On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg wrote: > Will the

Re: [PATCH v4 07/31] kconfig: add built-in function support

2018-05-22 0:10 GMT+09:00 Ulf Magnusson : > On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson wrote: >> On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson wrote: >>> On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg wrote:

Re: [PATCH v4 07/31] kconfig: add built-in function support

2018-05-22 0:10 GMT+09:00 Ulf Magnusson : > On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson wrote: >> On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson wrote: >>> On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg wrote: Will the following be equal: $(foo,abc,$(x),$(y))

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson wrote: > On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson wrote: >> On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg wrote: >>> Will the following be equal: >>> >>>

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson wrote: > On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson wrote: >> On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg wrote: >>> Will the following be equal: >>> >>> $(foo,abc,$(x),$(y)) >>> $(foo, abc, $(x), $(y)) >>> >>> make is rather

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson wrote: > On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg wrote: >> Will the following be equal: >> >> $(foo,abc,$(x),$(y)) >> $(foo, abc, $(x), $(y)) >> >> make is rather annoying as space is

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson wrote: > On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg wrote: >> Will the following be equal: >> >> $(foo,abc,$(x),$(y)) >> $(foo, abc, $(x), $(y)) >> >> make is rather annoying as space is significant, but there seems no good >>

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg wrote: > Will the following be equal: > > $(foo,abc,$(x),$(y)) > $(foo, abc, $(x), $(y)) > > make is rather annoying as space is significant, but there seems no good > reason > for kconfig to inheritate this. > So

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg wrote: > Will the following be equal: > > $(foo,abc,$(x),$(y)) > $(foo, abc, $(x), $(y)) > > make is rather annoying as space is significant, but there seems no good > reason > for kconfig to inheritate this. > So unless there are

Re: [PATCH v4 07/31] kconfig: add built-in function support

Hi Masahiro, > Hmm, your suggestion is more shell-oriented parsing. ... > Probably, I found it was much more complex, > then I chose Make-like simpler one. Agree that the simple one should be the best choice for now. We shall not add anything more complex unless it is really needed. Sam

Re: [PATCH v4 07/31] kconfig: add built-in function support

Hi Masahiro, > Hmm, your suggestion is more shell-oriented parsing. ... > Probably, I found it was much more complex, > then I chose Make-like simpler one. Agree that the simple one should be the best choice for now. We shall not add anything more complex unless it is really needed. Sam

Re: [PATCH v4 07/31] kconfig: add built-in function support

Hi Sam, 2018-05-21 15:16 GMT+09:00 Sam Ravnborg : > Hi Masahiro > >> >> + char *(*func)(int argc, char *argv[], int old_argc, char >> >> *old_argv[]); >> >> +}; >> > If a typedef was provided for the function then ... >> >> >> Yes, I can do this, >> but I may rather

Re: [PATCH v4 07/31] kconfig: add built-in function support

Hi Sam, 2018-05-21 15:16 GMT+09:00 Sam Ravnborg : > Hi Masahiro > >> >> + char *(*func)(int argc, char *argv[], int old_argc, char >> >> *old_argv[]); >> >> +}; >> > If a typedef was provided for the function then ... >> >> >> Yes, I can do this, >> but I may rather consider to simplify the

Re: [PATCH v4 07/31] kconfig: add built-in function support

Hi Masahiro > >> + char *(*func)(int argc, char *argv[], int old_argc, char > >> *old_argv[]); > >> +}; > > If a typedef was provided for the function then ... > > > Yes, I can do this, > but I may rather consider to simplify the code. Simplify is better. > > Will the following be equal:

Re: [PATCH v4 07/31] kconfig: add built-in function support

Hi Masahiro > >> + char *(*func)(int argc, char *argv[], int old_argc, char > >> *old_argv[]); > >> +}; > > If a typedef was provided for the function then ... > > > Yes, I can do this, > but I may rather consider to simplify the code. Simplify is better. > > Will the following be equal:

Re: [PATCH v4 07/31] kconfig: add built-in function support

Sam, 2018-05-20 23:50 GMT+09:00 Sam Ravnborg : > On Thu, May 17, 2018 at 03:16:46PM +0900, Masahiro Yamada wrote: >> This commit adds a new concept 'function' to do more text processing >> in Kconfig. >> >> A function call looks like this: >> >> $(function,arg1,arg2,arg3,...)

Re: [PATCH v4 07/31] kconfig: add built-in function support

Sam, 2018-05-20 23:50 GMT+09:00 Sam Ravnborg : > On Thu, May 17, 2018 at 03:16:46PM +0900, Masahiro Yamada wrote: >> This commit adds a new concept 'function' to do more text processing >> in Kconfig. >> >> A function call looks like this: >> >> $(function,arg1,arg2,arg3,...) >> >> This commit

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Thu, May 17, 2018 at 03:16:46PM +0900, Masahiro Yamada wrote: > This commit adds a new concept 'function' to do more text processing > in Kconfig. > > A function call looks like this: > > $(function,arg1,arg2,arg3,...) > > This commit adds the basic infrastructure to expand functions. >

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Thu, May 17, 2018 at 03:16:46PM +0900, Masahiro Yamada wrote: > This commit adds a new concept 'function' to do more text processing > in Kconfig. > > A function call looks like this: > > $(function,arg1,arg2,arg3,...) > > This commit adds the basic infrastructure to expand functions. >

[PATCH v4 07/31] kconfig: add built-in function support

This commit adds a new concept 'function' to do more text processing in Kconfig. A function call looks like this: $(function,arg1,arg2,arg3,...) This commit adds the basic infrastructure to expand functions. Change the text expansion helpers to take arguments. Signed-off-by: Masahiro Yamada

[PATCH v4 07/31] kconfig: add built-in function support

This commit adds a new concept 'function' to do more text processing in Kconfig. A function call looks like this: $(function,arg1,arg2,arg3,...) This commit adds the basic infrastructure to expand functions. Change the text expansion helpers to take arguments. Signed-off-by: Masahiro Yamada