Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-12-01 Thread Dave Young
On 11/29/13 at 05:47pm, Borislav Petkov wrote: > On Fri, Nov 29, 2013 at 04:50:50PM +0800, Dave Young wrote: > > It's for debugging purpose, I think it's helpful. > > Why? The first kernel did dump it already. As for the efi printk though 1st kernel already printed them out, but kexec kernel

Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-12-01 Thread Dave Young
On 11/29/13 at 05:47pm, Borislav Petkov wrote: On Fri, Nov 29, 2013 at 04:50:50PM +0800, Dave Young wrote: It's for debugging purpose, I think it's helpful. Why? The first kernel did dump it already. As for the efi printk though 1st kernel already printed them out, but kexec kernel context

Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-29 Thread Borislav Petkov
On Fri, Nov 29, 2013 at 04:50:50PM +0800, Dave Young wrote: > It's for debugging purpose, I think it's helpful. Why? The first kernel did dump it already. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line

Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-29 Thread Dave Young
On 11/27/13 at 03:27pm, Borislav Petkov wrote: > On Wed, Nov 27, 2013 at 10:27:01AM +, Matt Fleming wrote: > > Heh, you can probably already guess what I'm going to say here... > > I guessed :-) > > > How about using a single function to dump the memory ranges irrespective > > of whether the

Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-29 Thread Dave Young
On 11/27/13 at 10:27am, Matt Fleming wrote: > On Tue, 26 Nov, at 01:57:53PM, Dave Young wrote: > > For kexec/kdump kernel efi runtime mappings are saved, printing original > > whole > > memmap ranges does not make sense anymore. So introduce a new function to > > only > > print runtime maps in

Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-29 Thread Dave Young
On 11/27/13 at 10:27am, Matt Fleming wrote: On Tue, 26 Nov, at 01:57:53PM, Dave Young wrote: For kexec/kdump kernel efi runtime mappings are saved, printing original whole memmap ranges does not make sense anymore. So introduce a new function to only print runtime maps in case

Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-29 Thread Dave Young
On 11/27/13 at 03:27pm, Borislav Petkov wrote: On Wed, Nov 27, 2013 at 10:27:01AM +, Matt Fleming wrote: Heh, you can probably already guess what I'm going to say here... I guessed :-) How about using a single function to dump the memory ranges irrespective of whether the memory

Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-29 Thread Borislav Petkov
On Fri, Nov 29, 2013 at 04:50:50PM +0800, Dave Young wrote: It's for debugging purpose, I think it's helpful. Why? The first kernel did dump it already. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line

Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-27 Thread Borislav Petkov
On Wed, Nov 27, 2013 at 10:27:01AM +, Matt Fleming wrote: > Heh, you can probably already guess what I'm going to say here... I guessed :-) > How about using a single function to dump the memory ranges irrespective > of whether the memory map comes from 'memmap' or 'esdata'? e.g. > something

Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-27 Thread Matt Fleming
On Tue, 26 Nov, at 01:57:53PM, Dave Young wrote: > For kexec/kdump kernel efi runtime mappings are saved, printing original whole > memmap ranges does not make sense anymore. So introduce a new function to only > print runtime maps in case kexec/kdump kernel is used. > > Signed-off-by: Dave Young

Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-27 Thread Matt Fleming
On Tue, 26 Nov, at 01:57:53PM, Dave Young wrote: For kexec/kdump kernel efi runtime mappings are saved, printing original whole memmap ranges does not make sense anymore. So introduce a new function to only print runtime maps in case kexec/kdump kernel is used. Signed-off-by: Dave Young

Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-27 Thread Borislav Petkov
On Wed, Nov 27, 2013 at 10:27:01AM +, Matt Fleming wrote: Heh, you can probably already guess what I'm going to say here... I guessed :-) How about using a single function to dump the memory ranges irrespective of whether the memory map comes from 'memmap' or 'esdata'? e.g. something

[PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-25 Thread Dave Young
For kexec/kdump kernel efi runtime mappings are saved, printing original whole memmap ranges does not make sense anymore. So introduce a new function to only print runtime maps in case kexec/kdump kernel is used. Signed-off-by: Dave Young --- arch/x86/platform/efi/efi.c | 23

[PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

2013-11-25 Thread Dave Young
For kexec/kdump kernel efi runtime mappings are saved, printing original whole memmap ranges does not make sense anymore. So introduce a new function to only print runtime maps in case kexec/kdump kernel is used. Signed-off-by: Dave Young dyo...@redhat.com --- arch/x86/platform/efi/efi.c | 23