Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-29 Thread Casey Schaufler
On 10/14/2015 5:42 AM, Lukasz Pawelczyk wrote: > This commit introduces several changes to Smack to prepare it for > namespace implementation. All the changes are related to namespaces. > > Overview of the changes: > - Adds required data structures for mapped labels and functions to > operate on

Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-29 Thread Casey Schaufler
On 10/14/2015 5:42 AM, Lukasz Pawelczyk wrote: > This commit introduces several changes to Smack to prepare it for > namespace implementation. All the changes are related to namespaces. > > Overview of the changes: > - Adds required data structures for mapped labels and functions to > operate on

Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-16 Thread Lukasz Pawelczyk
On pią, 2015-10-16 at 11:04 +0800, Hillf Danton wrote: > > + > > static inline void smack_userns_free(struct user_namespace *ns) > > { > > struct smack_ns *snsp = ns->security; > > @@ -4680,12 +4689,11 @@ static inline void smack_userns_free(struct > > user_namespace *ns) > > > >

Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-16 Thread Lukasz Pawelczyk
On pią, 2015-10-16 at 11:04 +0800, Hillf Danton wrote: > > + > > static inline void smack_userns_free(struct user_namespace *ns) > > { > > struct smack_ns *snsp = ns->security; > > @@ -4680,12 +4689,11 @@ static inline void smack_userns_free(struct > > user_namespace *ns) > > > >

Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-15 Thread Hillf Danton
> On czw, 2015-10-15 at 14:41 +0200, Lukasz Pawelczyk wrote: > > > No, not a typo. A regular bug. Thanks for spotting it. Also sync > > mechanism before freeing was missing: > > > Hitfix, will be integrated with the next respin: > > diff --git a/security/smack/smack.h b/security/smack/smack.h

Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-15 Thread Lukasz Pawelczyk
On czw, 2015-10-15 at 14:41 +0200, Lukasz Pawelczyk wrote: > No, not a typo. A regular bug. Thanks for spotting it. Also sync > mechanism before freeing was missing: Hitfix, will be integrated with the next respin: diff --git a/security/smack/smack.h b/security/smack/smack.h index

Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-15 Thread Lukasz Pawelczyk
On czw, 2015-10-15 at 15:38 +0800, Hillf Danton wrote: > > > > +static inline void smack_userns_free(struct user_namespace *ns) > > +{ > > + struct smack_ns *snsp = ns->security; > > + struct smack_known *skp; > > + struct smack_known_ns *sknp, *n; > > + > > +

Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-15 Thread Hillf Danton
> > +static inline void smack_userns_free(struct user_namespace *ns) > +{ > + struct smack_ns *snsp = ns->security; > + struct smack_known *skp; > + struct smack_known_ns *sknp, *n; > + > + list_for_each_entry_safe(sknp, n, >smk_mapped, smk_list_ns) { > + skp =

Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-15 Thread Lukasz Pawelczyk
On czw, 2015-10-15 at 15:38 +0800, Hillf Danton wrote: > > > > +static inline void smack_userns_free(struct user_namespace *ns) > > +{ > > + struct smack_ns *snsp = ns->security; > > + struct smack_known *skp; > > + struct smack_known_ns *sknp, *n; > > + > > +

Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-15 Thread Lukasz Pawelczyk
On czw, 2015-10-15 at 14:41 +0200, Lukasz Pawelczyk wrote: > No, not a typo. A regular bug. Thanks for spotting it. Also sync > mechanism before freeing was missing: Hitfix, will be integrated with the next respin: diff --git a/security/smack/smack.h b/security/smack/smack.h index

Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-15 Thread Hillf Danton
> > +static inline void smack_userns_free(struct user_namespace *ns) > +{ > + struct smack_ns *snsp = ns->security; > + struct smack_known *skp; > + struct smack_known_ns *sknp, *n; > + > + list_for_each_entry_safe(sknp, n, >smk_mapped, smk_list_ns) { > + skp =

Re: [PATCH v4 09/11] smack: namespace groundwork

2015-10-15 Thread Hillf Danton
> On czw, 2015-10-15 at 14:41 +0200, Lukasz Pawelczyk wrote: > > > No, not a typo. A regular bug. Thanks for spotting it. Also sync > > mechanism before freeing was missing: > > > Hitfix, will be integrated with the next respin: > > diff --git a/security/smack/smack.h b/security/smack/smack.h

[PATCH v4 09/11] smack: namespace groundwork

2015-10-14 Thread Lukasz Pawelczyk
This commit introduces several changes to Smack to prepare it for namespace implementation. All the changes are related to namespaces. Overview of the changes: - Adds required data structures for mapped labels and functions to operate on them. - Implements the proc interface

[PATCH v4 09/11] smack: namespace groundwork

2015-10-14 Thread Lukasz Pawelczyk
This commit introduces several changes to Smack to prepare it for namespace implementation. All the changes are related to namespaces. Overview of the changes: - Adds required data structures for mapped labels and functions to operate on them. - Implements the proc interface