Re: [PATCH v4 09/24] fpga: dfl-pci: add enumeration for feature devices

2018-03-14 Thread Alan Tull
On Wed, Mar 14, 2018 at 12:21 AM, Wu Hao wrote: >> > + >> > + drvdata->cdev = cdev; >> > + >> > +enum_info_free_exit: >> > + fpga_enum_info_free(info); >> >> This is the only place I saw fpga_enum_info_free being called. > > It doesn't need to keep the enumeration

Re: [PATCH v4 09/24] fpga: dfl-pci: add enumeration for feature devices

2018-03-14 Thread Alan Tull
On Wed, Mar 14, 2018 at 12:21 AM, Wu Hao wrote: >> > + >> > + drvdata->cdev = cdev; >> > + >> > +enum_info_free_exit: >> > + fpga_enum_info_free(info); >> >> This is the only place I saw fpga_enum_info_free being called. > > It doesn't need to keep the enumeration inforamtion data

Re: [PATCH v4 09/24] fpga: dfl-pci: add enumeration for feature devices

2018-03-13 Thread Wu Hao
On Tue, Mar 13, 2018 at 01:30:24PM -0500, Alan Tull wrote: > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > Hi Hao, > > Thanks again for splitting the pci part of the code from enumeration > and everything else. > > One thing that may need to be fixed below, so with that

Re: [PATCH v4 09/24] fpga: dfl-pci: add enumeration for feature devices

2018-03-13 Thread Wu Hao
On Tue, Mar 13, 2018 at 01:30:24PM -0500, Alan Tull wrote: > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > Hi Hao, > > Thanks again for splitting the pci part of the code from enumeration > and everything else. > > One thing that may need to be fixed below, so with that fixed, adding my

Re: [PATCH v4 09/24] fpga: dfl-pci: add enumeration for feature devices

2018-03-13 Thread Alan Tull
On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: Hi Hao, Thanks again for splitting the pci part of the code from enumeration and everything else. One thing that may need to be fixed below, so with that fixed, adding my ack. > The Device Feature List (DFL) is implemented in

Re: [PATCH v4 09/24] fpga: dfl-pci: add enumeration for feature devices

2018-03-13 Thread Alan Tull
On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: Hi Hao, Thanks again for splitting the pci part of the code from enumeration and everything else. One thing that may need to be fixed below, so with that fixed, adding my ack. > The Device Feature List (DFL) is implemented in MMIO, and features >

[PATCH v4 09/24] fpga: dfl-pci: add enumeration for feature devices

2018-02-13 Thread Wu Hao
The Device Feature List (DFL) is implemented in MMIO, and features are linked via the DFLs. This patch enables pcie driver to prepare enumeration information (e.g locations of all device feature lists in MMIO) and use common APIs provided by the Device Feature List framework to enumerate each

[PATCH v4 09/24] fpga: dfl-pci: add enumeration for feature devices

2018-02-13 Thread Wu Hao
The Device Feature List (DFL) is implemented in MMIO, and features are linked via the DFLs. This patch enables pcie driver to prepare enumeration information (e.g locations of all device feature lists in MMIO) and use common APIs provided by the Device Feature List framework to enumerate each