Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors

2019-10-02 Thread Hawa, Hanna
On 9/30/2019 5:50 PM, Borislav Petkov wrote: On Mon, Sep 23, 2019 at 08:17:40PM +0100, Hanna Hawa wrote: +void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev, + int inst_nr, int block_nr, const char *msg) +{ + __edac_device_handle_ce(edac_dev, 1,

Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors

2019-10-01 Thread Robert Richter
On 01.10.19 12:25:39, Borislav Petkov wrote: > On Tue, Oct 01, 2019 at 09:47:07AM +, Robert Richter wrote: > > If you move to static inline for edac_device_handle_{ce,ue} the > > symbols vanish and this breaks the abi. That's why the split in two > > patches. > > ABI issues do not concern

Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors

2019-10-01 Thread Borislav Petkov
On Tue, Oct 01, 2019 at 09:47:07AM +, Robert Richter wrote: > If you move to static inline for edac_device_handle_{ce,ue} the > symbols vanish and this breaks the abi. That's why the split in two > patches. ABI issues do not concern upstream. And that coming from me working at a company who

Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors

2019-10-01 Thread Robert Richter
On 01.10.19 10:32:42, Borislav Petkov wrote: > -- > On Tue, Oct 01, 2019 at 06:56:58AM +, Robert Richter wrote: > > It is *not* the counterpart. The __* version already has the... > > Lemme cut to the chase: > > "Make the

Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors

2019-10-01 Thread Borislav Petkov
On Tue, Oct 01, 2019 at 06:56:58AM +, Robert Richter wrote: > It is *not* the counterpart. The __* version already has the... Lemme cut to the chase: "Make the main workhorse the "count" functions which can log a @count of errors. Have the current APIs edac_device_handle_{ce,ue}() call the

Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors

2019-10-01 Thread Robert Richter
On 30.09.19 16:50:46, Borislav Petkov wrote: > -- > On Mon, Sep 23, 2019 at 08:17:40PM +0100, Hanna Hawa wrote: > > +void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev, > > + int inst_nr, int

Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors

2019-09-30 Thread Borislav Petkov
On Mon, Sep 23, 2019 at 08:17:40PM +0100, Hanna Hawa wrote: > +void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev, > + int inst_nr, int block_nr, const char *msg) > +{ > + __edac_device_handle_ce(edac_dev, 1, inst_nr, block_nr, msg); > +} >

[PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors

2019-09-23 Thread Hanna Hawa
Add an API for EDAC device to report multiple errors with same type. Signed-off-by: Hanna Hawa Acked-by: Robert Richter --- drivers/edac/edac_device.c | 56 -- drivers/edac/edac_device.h | 47 2 files changed, 83