Re: [PATCH v4 1/2] sched/uclamp: Fix initialization of struct uclamp_rq

2020-06-29 Thread Qais Yousef
Hi Patrick On 06/26/20 14:32, Patrick Bellasi wrote: > > On Thu, Jun 25, 2020 at 17:43:51 +0200, Qais Yousef > wrote... > > > struct uclamp_rq was zeroed out entirely in assumption that in the first > > call to uclamp_rq_inc() they'd be initialized correctly in accordance to > > default

Re: [PATCH v4 1/2] sched/uclamp: Fix initialization of struct uclamp_rq

2020-06-26 Thread Valentin Schneider
On 26/06/20 13:32, Patrick Bellasi wrote: > On Thu, Jun 25, 2020 at 17:43:51 +0200, Qais Yousef > wrote... > >> struct uclamp_rq was zeroed out entirely in assumption that in the first >> call to uclamp_rq_inc() they'd be initialized correctly in accordance to >> default settings. > > Perhaps

Re: [PATCH v4 1/2] sched/uclamp: Fix initialization of struct uclamp_rq

2020-06-26 Thread Patrick Bellasi
On Thu, Jun 25, 2020 at 17:43:51 +0200, Qais Yousef wrote... > struct uclamp_rq was zeroed out entirely in assumption that in the first > call to uclamp_rq_inc() they'd be initialized correctly in accordance to > default settings. Perhaps I was not clear in my previous comment:

[PATCH v4 1/2] sched/uclamp: Fix initialization of struct uclamp_rq

2020-06-25 Thread Qais Yousef
struct uclamp_rq was zeroed out entirely in assumption that in the first call to uclamp_rq_inc() they'd be initialized correctly in accordance to default settings. But when next patch introduces a static key to skip uclamp_rq_{inc,dec}() until userspace opts in to use uclamp, schedutil will fail