Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

On Fri, May 31, 2013 at 03:05:50PM +0530, anish singh wrote: > Hi Guenter, > > On Fri, May 31, 2013 at 3:32 AM, Guenter Roeck wrote: > > On Thu, May 30, 2013 at 11:59:28PM +0200, Wim Van Sebroeck wrote: > >> Hi Guenter, > >> > >> > On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

Hi Guenter, On Fri, May 31, 2013 at 3:32 AM, Guenter Roeck wrote: > On Thu, May 30, 2013 at 11:59:28PM +0200, Wim Van Sebroeck wrote: >> Hi Guenter, >> >> > On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote: >> > > On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

Hi Guenther, On Thu, May 30, 2013 at 03:02:47PM -0700, Guenter Roeck wrote: > On Thu, May 30, 2013 at 11:59:28PM +0200, Wim Van Sebroeck wrote: > > Hi Guenter, > > [...] > > I even thought about adding this capability to the infrastructure. Actually this would be pretty nice to have > > Thanks,

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

Hi Guenther, On Thu, May 30, 2013 at 03:02:47PM -0700, Guenter Roeck wrote: On Thu, May 30, 2013 at 11:59:28PM +0200, Wim Van Sebroeck wrote: Hi Guenter, [...] I even thought about adding this capability to the infrastructure. Actually this would be pretty nice to have Thanks, Guenter

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

Hi Guenter, On Fri, May 31, 2013 at 3:32 AM, Guenter Roeck li...@roeck-us.net wrote: On Thu, May 30, 2013 at 11:59:28PM +0200, Wim Van Sebroeck wrote: Hi Guenter, On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote: On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

On Fri, May 31, 2013 at 03:05:50PM +0530, anish singh wrote: Hi Guenter, On Fri, May 31, 2013 at 3:32 AM, Guenter Roeck li...@roeck-us.net wrote: On Thu, May 30, 2013 at 11:59:28PM +0200, Wim Van Sebroeck wrote: Hi Guenter, On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

On Thu, May 30, 2013 at 11:59:28PM +0200, Wim Van Sebroeck wrote: > Hi Guenter, > > > On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote: > > > On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: > > > [...] > > > > > + watchdog_set_drvdata(_wdt, drv); > > > > >

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

Hi Guenter, > On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote: > > On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: > > [...] > > > > + watchdog_set_drvdata(_wdt, drv); > > > > > > I am missing the initialisation of the watchdog's timeout value here... >

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

Hi Johannes, > On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: > [...] > > > + watchdog_set_drvdata(_wdt, drv); > > > > I am missing the initialisation of the watchdog's timeout value here... > > This watchdog only knows two timeout values, 1s and 30s with the constraint > that

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

Hi Johannes, On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: [...] + watchdog_set_drvdata(a21_wdt, drv); I am missing the initialisation of the watchdog's timeout value here... This watchdog only knows two timeout values, 1s and 30s with the constraint that you

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

Hi Guenter, On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote: On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: [...] + watchdog_set_drvdata(a21_wdt, drv); I am missing the initialisation of the watchdog's timeout value here... This

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

On Thu, May 30, 2013 at 11:59:28PM +0200, Wim Van Sebroeck wrote: Hi Guenter, On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote: On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: [...] + watchdog_set_drvdata(a21_wdt, drv); I am missing

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

On Tue, May 28, 2013 at 09:22:18AM -0700, Guenter Roeck wrote: > On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote: > > On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: > > [...] > > > > + watchdog_set_drvdata(_wdt, drv); > > > > > > I am missing the

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

On Tue, May 28, 2013 at 09:22:18AM -0700, Guenter Roeck wrote: On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote: On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: [...] + watchdog_set_drvdata(a21_wdt, drv); I am missing the initialisation of

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote: > On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: > [...] > > > + watchdog_set_drvdata(_wdt, drv); > > > > I am missing the initialisation of the watchdog's timeout value here... > > This watchdog only knows two

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: [...] > > + watchdog_set_drvdata(_wdt, drv); > > I am missing the initialisation of the watchdog's timeout value here... This watchdog only knows two timeout values, 1s and 30s with the constraint that you can't go back to 30s

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: [...] + watchdog_set_drvdata(a21_wdt, drv); I am missing the initialisation of the watchdog's timeout value here... This watchdog only knows two timeout values, 1s and 30s with the constraint that you can't go back to 30s

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote: On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: [...] + watchdog_set_drvdata(a21_wdt, drv); I am missing the initialisation of the watchdog's timeout value here... This watchdog only knows two timeout

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

Hi Johannes, > This patch adds the driver for the watchdog devices found on MEN Mikro > Elektronik A21 VMEbus CPU Carrier Boards. It has DT-support and uses the > watchdog framework. > > Revision 2: > * Removed unneeded open flag in struct a21_wdt_drv > * Corrected 3bit reason code from gpio > *

[PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

From: Johannes Thumshirn This patch adds the driver for the watchdog devices found on MEN Mikro Elektronik A21 VMEbus CPU Carrier Boards. It has DT-support and uses the watchdog framework. Revision 2: * Removed unneeded open flag in struct a21_wdt_drv * Corrected 3bit reason code from gpio *

[PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

From: Johannes Thumshirn johannes.thumsh...@men.de This patch adds the driver for the watchdog devices found on MEN Mikro Elektronik A21 VMEbus CPU Carrier Boards. It has DT-support and uses the watchdog framework. Revision 2: * Removed unneeded open flag in struct a21_wdt_drv * Corrected 3bit

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

Hi Johannes, This patch adds the driver for the watchdog devices found on MEN Mikro Elektronik A21 VMEbus CPU Carrier Boards. It has DT-support and uses the watchdog framework. Revision 2: * Removed unneeded open flag in struct a21_wdt_drv * Corrected 3bit reason code from gpio *