Re: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-20 Thread Markus Mayer
On 20 November 2013 10:40, Guenter Roeck wrote: > On Wed, Nov 20, 2013 at 10:24:54AM -0800, Markus Mayer wrote: >> > Hi Markus, >> > >> > Yes, I noticed when I merged it into my watchdog-next branch. >> > >> > Reminds me ... v3 had a whitespace problem. I don't recall if you fixed >> > that in

Re: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-20 Thread Guenter Roeck
On Wed, Nov 20, 2013 at 10:24:54AM -0800, Markus Mayer wrote: > > Hi Markus, > > > > Yes, I noticed when I merged it into my watchdog-next branch. > > > > Reminds me ... v3 had a whitespace problem. I don't recall if you fixed > > that in v4. If you didn't, that might be a better reason to send

Re: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-20 Thread Markus Mayer
> Hi Markus, > > Yes, I noticed when I merged it into my watchdog-next branch. > > Reminds me ... v3 had a whitespace problem. I don't recall if you fixed > that in v4. If you didn't, that might be a better reason to send v5. That's still there, unfortunately. Trailing space on the first

Re: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-20 Thread Guenter Roeck
On Wed, Nov 20, 2013 at 08:12:37AM -0800, Markus Mayer wrote: > On 19 November 2013 11:07, Markus Mayer wrote: > > This commit adds support for the watchdog timer used on the BCM281xx > > family of SoCs. > > > > Signed-off-by: Markus Mayer > > Reviewed-by: Matt Porter > > Reviewed-by: Guenter

Re: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-20 Thread Markus Mayer
On 19 November 2013 11:07, Markus Mayer wrote: > This commit adds support for the watchdog timer used on the BCM281xx > family of SoCs. > > Signed-off-by: Markus Mayer > Reviewed-by: Matt Porter > Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig| 22 +++ >

Re: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-20 Thread Markus Mayer
On 19 November 2013 11:07, Markus Mayer markus.ma...@linaro.org wrote: This commit adds support for the watchdog timer used on the BCM281xx family of SoCs. Signed-off-by: Markus Mayer markus.ma...@linaro.org Reviewed-by: Matt Porter matt.por...@linaro.org Reviewed-by: Guenter Roeck

Re: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-20 Thread Guenter Roeck
On Wed, Nov 20, 2013 at 08:12:37AM -0800, Markus Mayer wrote: On 19 November 2013 11:07, Markus Mayer markus.ma...@linaro.org wrote: This commit adds support for the watchdog timer used on the BCM281xx family of SoCs. Signed-off-by: Markus Mayer markus.ma...@linaro.org Reviewed-by: Matt

Re: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-20 Thread Markus Mayer
Hi Markus, Yes, I noticed when I merged it into my watchdog-next branch. Reminds me ... v3 had a whitespace problem. I don't recall if you fixed that in v4. If you didn't, that might be a better reason to send v5. That's still there, unfortunately. Trailing space on the first help-text line

Re: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-20 Thread Guenter Roeck
On Wed, Nov 20, 2013 at 10:24:54AM -0800, Markus Mayer wrote: Hi Markus, Yes, I noticed when I merged it into my watchdog-next branch. Reminds me ... v3 had a whitespace problem. I don't recall if you fixed that in v4. If you didn't, that might be a better reason to send v5. That's

Re: [PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-20 Thread Markus Mayer
On 20 November 2013 10:40, Guenter Roeck li...@roeck-us.net wrote: On Wed, Nov 20, 2013 at 10:24:54AM -0800, Markus Mayer wrote: Hi Markus, Yes, I noticed when I merged it into my watchdog-next branch. Reminds me ... v3 had a whitespace problem. I don't recall if you fixed that in v4.

[PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-19 Thread Markus Mayer
This commit adds support for the watchdog timer used on the BCM281xx family of SoCs. Signed-off-by: Markus Mayer Reviewed-by: Matt Porter Reviewed-by: Guenter Roeck --- drivers/watchdog/Kconfig| 22 +++ drivers/watchdog/Makefile |1 + drivers/watchdog/bcm_kona_wdt.c | 365

[PATCH v4 1/2] watchdog: bcm281xx: Watchdog Driver

2013-11-19 Thread Markus Mayer
This commit adds support for the watchdog timer used on the BCM281xx family of SoCs. Signed-off-by: Markus Mayer markus.ma...@linaro.org Reviewed-by: Matt Porter matt.por...@linaro.org Reviewed-by: Guenter Roeck li...@roeck-us.net --- drivers/watchdog/Kconfig| 22 +++