Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-05 Thread Nickey Yang
Hi Brian, On 2017年12月06日 02:56, Brian Norris wrote: Hi Nickey, On Tue, Dec 05, 2017 at 05:14:11PM +0800, Nickey Yang wrote: On 2017年12月01日 18:07, Philippe CORNU wrote: On 12/01/2017 10:11 AM, Nickey Yang wrote: On 2017年12月01日 16:32, Philippe CORNU wrote: I am sorry to say that but you can

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-05 Thread Nickey Yang
Hi Brian, On 2017年12月06日 02:56, Brian Norris wrote: Hi Nickey, On Tue, Dec 05, 2017 at 05:14:11PM +0800, Nickey Yang wrote: On 2017年12月01日 18:07, Philippe CORNU wrote: On 12/01/2017 10:11 AM, Nickey Yang wrote: On 2017年12月01日 16:32, Philippe CORNU wrote: I am sorry to say that but you can

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-05 Thread Brian Norris
Hi Nickey, On Tue, Dec 05, 2017 at 05:14:11PM +0800, Nickey Yang wrote: > On 2017年12月01日 18:07, Philippe CORNU wrote: > >On 12/01/2017 10:11 AM, Nickey Yang wrote: > >>On 2017年12月01日 16:32, Philippe CORNU wrote: > >>>I am sorry to say that but you can not add my "Acked-by" to this patch >

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-05 Thread Brian Norris
Hi Nickey, On Tue, Dec 05, 2017 at 05:14:11PM +0800, Nickey Yang wrote: > On 2017年12月01日 18:07, Philippe CORNU wrote: > >On 12/01/2017 10:11 AM, Nickey Yang wrote: > >>On 2017年12月01日 16:32, Philippe CORNU wrote: > >>>I am sorry to say that but you can not add my "Acked-by" to this patch >

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-05 Thread Nickey Yang
Hi Philippe, On 2017年12月01日 18:07, Philippe CORNU wrote: Hi Nickey, On 12/01/2017 10:11 AM, Nickey Yang wrote: Hi Philippe, On 2017年12月01日 16:32, Philippe CORNU wrote: Dear Nickey, Many thanks for your patch. I am sorry to say that but you can not add my "Acked-by" to this patch because

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-05 Thread Nickey Yang
Hi Philippe, On 2017年12月01日 18:07, Philippe CORNU wrote: Hi Nickey, On 12/01/2017 10:11 AM, Nickey Yang wrote: Hi Philippe, On 2017年12月01日 16:32, Philippe CORNU wrote: Dear Nickey, Many thanks for your patch. I am sorry to say that but you can not add my "Acked-by" to this patch because

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-01 Thread Emil Velikov
On 1 December 2017 at 08:32, Philippe CORNU wrote: > Dear Nickey, > > Many thanks for your patch. > > I am sorry to say that but you can not add my "Acked-by" to this patch > because this code is different from the "original" one from Brian (which > got my "Acked-by"). >

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-01 Thread Emil Velikov
On 1 December 2017 at 08:32, Philippe CORNU wrote: > Dear Nickey, > > Many thanks for your patch. > > I am sorry to say that but you can not add my "Acked-by" to this patch > because this code is different from the "original" one from Brian (which > got my "Acked-by"). > Small idea: I've seen

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-01 Thread Philippe CORNU
Hi Nickey, On 12/01/2017 10:11 AM, Nickey Yang wrote: > Hi Philippe, > > > On 2017年12月01日 16:32, Philippe CORNU wrote: >> Dear Nickey, >> >> Many thanks for your patch. >> >> I am sorry to say that but you can not add my "Acked-by" to this patch >> because this code is different from the

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-01 Thread Philippe CORNU
Hi Nickey, On 12/01/2017 10:11 AM, Nickey Yang wrote: > Hi Philippe, > > > On 2017年12月01日 16:32, Philippe CORNU wrote: >> Dear Nickey, >> >> Many thanks for your patch. >> >> I am sorry to say that but you can not add my "Acked-by" to this patch >> because this code is different from the

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-01 Thread Philippe CORNU
Dear Nickey, Many thanks for your patch. I am sorry to say that but you can not add my "Acked-by" to this patch because this code is different from the "original" one from Brian (which got my "Acked-by"). Sometimes it is not an issue because differences are not important but in this

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-01 Thread Philippe CORNU
Dear Nickey, Many thanks for your patch. I am sorry to say that but you can not add my "Acked-by" to this patch because this code is different from the "original" one from Brian (which got my "Acked-by"). Sometimes it is not an issue because differences are not important but in this

[PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-11-30 Thread Nickey Yang
From: Brian Norris Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris

[PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-11-30 Thread Nickey Yang
From: Brian Norris Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris Signed-off-by: Nickey Yang Reviewed-by: