Re: [PATCH v4 1/3] hwmon: (lm90) Add power control

2013-09-15 Thread Wei Ni
On 09/12/2013 07:51 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Thu, Sep 12, 2013 at 07:24:19PM +0800, Wei Ni wrote: > >> +#include > > You don't need this any more, otherwise Oh, yes, I will remove it. > > Reviewed-by: Mark Brown > > * Unknown Key > * 0x7EA229BD > --

Re: [PATCH v4 1/3] hwmon: (lm90) Add power control

2013-09-15 Thread Wei Ni
On 09/12/2013 07:51 PM, Mark Brown wrote: * PGP Signed by an unknown key On Thu, Sep 12, 2013 at 07:24:19PM +0800, Wei Ni wrote: +#include linux/delay.h You don't need this any more, otherwise Oh, yes, I will remove it. Reviewed-by: Mark Brown broo...@linaro.org * Unknown Key *

Re: [PATCH v4 1/3] hwmon: (lm90) Add power control

2013-09-12 Thread Guenter Roeck
On 09/12/2013 04:24 AM, Wei Ni wrote: The device lm90 can be controlled by the vcc rail. Adding the regulator support to power on/off the vcc rail. Enable the "vcc" regulator before accessing the device. Signed-off-by: Wei Ni I still believe that you should update all .dts files referencing

Re: [PATCH v4 1/3] hwmon: (lm90) Add power control

2013-09-12 Thread Mark Brown
On Thu, Sep 12, 2013 at 07:24:19PM +0800, Wei Ni wrote: > +#include You don't need this any more, otherwise Reviewed-by: Mark Brown signature.asc Description: Digital signature

[PATCH v4 1/3] hwmon: (lm90) Add power control

2013-09-12 Thread Wei Ni
The device lm90 can be controlled by the vcc rail. Adding the regulator support to power on/off the vcc rail. Enable the "vcc" regulator before accessing the device. Signed-off-by: Wei Ni --- drivers/hwmon/lm90.c | 20 1 file changed, 20 insertions(+) diff --git

[PATCH v4 1/3] hwmon: (lm90) Add power control

2013-09-12 Thread Wei Ni
The device lm90 can be controlled by the vcc rail. Adding the regulator support to power on/off the vcc rail. Enable the vcc regulator before accessing the device. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 20 1 file changed, 20 insertions(+) diff

Re: [PATCH v4 1/3] hwmon: (lm90) Add power control

2013-09-12 Thread Mark Brown
On Thu, Sep 12, 2013 at 07:24:19PM +0800, Wei Ni wrote: +#include linux/delay.h You don't need this any more, otherwise Reviewed-by: Mark Brown broo...@linaro.org signature.asc Description: Digital signature

Re: [PATCH v4 1/3] hwmon: (lm90) Add power control

2013-09-12 Thread Guenter Roeck
On 09/12/2013 04:24 AM, Wei Ni wrote: The device lm90 can be controlled by the vcc rail. Adding the regulator support to power on/off the vcc rail. Enable the vcc regulator before accessing the device. Signed-off-by: Wei Ni w...@nvidia.com I still believe that you should update all .dts files