Re: [PATCH v4 1/3] nvme/scsi: Remove power management support

2016-09-16 Thread J Freyensee
On Fri, 2016-09-16 at 11:16 -0700, Andy Lutomirski wrote: > As far as I can tell, there is basically nothing correct about this > code.  It misinterprets npss (off-by-one).  It hardcodes a bunch of > power states, which is nonsense, because they're all just indices > into a table that software

Re: [PATCH v4 1/3] nvme/scsi: Remove power management support

2016-09-16 Thread J Freyensee
On Fri, 2016-09-16 at 11:16 -0700, Andy Lutomirski wrote: > As far as I can tell, there is basically nothing correct about this > code.  It misinterprets npss (off-by-one).  It hardcodes a bunch of > power states, which is nonsense, because they're all just indices > into a table that software

[PATCH v4 1/3] nvme/scsi: Remove power management support

2016-09-16 Thread Andy Lutomirski
As far as I can tell, there is basically nothing correct about this code. It misinterprets npss (off-by-one). It hardcodes a bunch of power states, which is nonsense, because they're all just indices into a table that software needs to parse. It completely ignores the distinction between

[PATCH v4 1/3] nvme/scsi: Remove power management support

2016-09-16 Thread Andy Lutomirski
As far as I can tell, there is basically nothing correct about this code. It misinterprets npss (off-by-one). It hardcodes a bunch of power states, which is nonsense, because they're all just indices into a table that software needs to parse. It completely ignores the distinction between