Re: [PATCH v4 1/4] iio: chemical: scd30: add core driver

2020-06-14 Thread Jonathan Cameron
On Sun, 7 Jun 2020 13:59:48 +0200 Tomasz Duszynski wrote: > On Sat, Jun 06, 2020 at 04:06:52PM +0100, Jonathan Cameron wrote: > > On Wed, 3 Jun 2020 10:44:38 +0200 > > Tomasz Duszynski wrote: > > > > > Add Sensirion SCD30 carbon dioxide core driver. > > > > > > Signed-off-by: Tomasz Duszynski

Re: [PATCH v4 1/4] iio: chemical: scd30: add core driver

2020-06-07 Thread Tomasz Duszynski
On Sat, Jun 06, 2020 at 04:06:52PM +0100, Jonathan Cameron wrote: > On Wed, 3 Jun 2020 10:44:38 +0200 > Tomasz Duszynski wrote: > > > Add Sensirion SCD30 carbon dioxide core driver. > > > > Signed-off-by: Tomasz Duszynski > > Hi Tomasz, > > One trivial suggestion on loosening a little what

Re: [PATCH v4 1/4] iio: chemical: scd30: add core driver

2020-06-06 Thread Jonathan Cameron
On Wed, 3 Jun 2020 10:44:38 +0200 Tomasz Duszynski wrote: > Add Sensirion SCD30 carbon dioxide core driver. > > Signed-off-by: Tomasz Duszynski Hi Tomasz, One trivial suggestion on loosening a little what counts as 'enabled' for the calibration enable. Otherwise, the ABI for providing the

[PATCH v4 1/4] iio: chemical: scd30: add core driver

2020-06-03 Thread Tomasz Duszynski
Add Sensirion SCD30 carbon dioxide core driver. Signed-off-by: Tomasz Duszynski --- Documentation/ABI/testing/sysfs-bus-iio-scd30 | 34 + MAINTAINERS | 6 + drivers/iio/chemical/Kconfig | 11 + drivers/iio/chemical/Makefile