Thanks for the review and comments. I will incorporate the comments
from you and Jingoo Han in next version.
-Tanmay
On Fri, Mar 14, 2014 at 5:18 AM, Arnd Bergmann wrote:
> On Thursday 06 March 2014, Tanmay Inamdar wrote:
>
>> +static inline void xgene_pcie_cfg_out16(void __iomem *addr, u16 val)
On Thursday 06 March 2014, Tanmay Inamdar wrote:
> +static inline void xgene_pcie_cfg_out16(void __iomem *addr, u16 val)
> +{
> + u64 temp_addr = (u64)addr & ~0x3;
Please use 'unsigned long' as the type for calculations like this one,
to make the code more portable. You mentioned before that
Thanks for reviewing and the comments. I will surely include them in
next version.
-Tanmay
On Fri, Mar 7, 2014 at 12:37 AM, Jingoo Han wrote:
> On Thursday, March 06, 2014 3:06 PM, Tanmay Inamdar wrote:
>>
>
> Hi Tanmay Inamdar,
>
> I added some minor comments. :-)
>
>> This patch adds the Appli
On Thursday, March 06, 2014 3:06 PM, Tanmay Inamdar wrote:
>
Hi Tanmay Inamdar,
I added some minor comments. :-)
> This patch adds the AppliedMicro X-Gene SOC PCIe controller driver.
> X-Gene PCIe controller supports maxmum upto 8 lanes and GEN3 speed.
Would you fix the followings?
s/maxmum/m
This patch adds the AppliedMicro X-Gene SOC PCIe controller driver.
X-Gene PCIe controller supports maxmum upto 8 lanes and GEN3 speed.
X-Gene SOC supports maximum 5 PCIe ports.
Signed-off-by: Tanmay Inamdar
---
drivers/pci/host/Kconfig | 10 +
drivers/pci/host/Makefile|1 +
driver
5 matches
Mail list logo
