Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

2020-08-04 Thread Greg KH
On Tue, Aug 04, 2020 at 10:11:19AM +0800, ivan wrote: > On Mon, Aug 3, 2020 at 7:57 PM Greg KH wrote: > > > > On Mon, Aug 03, 2020 at 01:49:50PM +0200, Sebastian Reichel wrote: > > > More importantely I prefer not to merge new APIs without any users > > > (i.e. a driver making use of those

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

2020-08-03 Thread ivan
On Mon, Aug 3, 2020 at 7:57 PM Greg KH wrote: > > On Mon, Aug 03, 2020 at 01:49:50PM +0200, Sebastian Reichel wrote: > > More importantely I prefer not to merge new APIs without any users > > (i.e. a driver making use of those values). Having a reference > > driver means, that there is an example

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

2020-08-03 Thread Greg KH
On Mon, Aug 03, 2020 at 01:49:50PM +0200, Sebastian Reichel wrote: > More importantely I prefer not to merge new APIs without any users > (i.e. a driver making use of those values). Having a reference > driver means, that there is an example how to use the values > correctly and proves it is

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

2020-08-03 Thread Sebastian Reichel
Hi, On Sun, Aug 02, 2020 at 06:57:38PM +0200, Greg KH wrote: > On Sun, Aug 02, 2020 at 04:28:25PM +0200, Pavel Machek wrote: > > On Sun 2020-08-02 14:37:42, Greg KH wrote: > > > On Sun, Aug 02, 2020 at 02:00:15PM +0200, Pavel Machek wrote: > > > > On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > >

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

2020-08-02 Thread Greg KH
On Sun, Aug 02, 2020 at 04:28:25PM +0200, Pavel Machek wrote: > On Sun 2020-08-02 14:37:42, Greg KH wrote: > > On Sun, Aug 02, 2020 at 02:00:15PM +0200, Pavel Machek wrote: > > > On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > > > > From: Qiwu Huang > > > > > > > > Reports the kind of quick

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

2020-08-02 Thread Pavel Machek
On Sun 2020-08-02 14:37:42, Greg KH wrote: > On Sun, Aug 02, 2020 at 02:00:15PM +0200, Pavel Machek wrote: > > On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > > > From: Qiwu Huang > > > > > > Reports the kind of quick charge type based on > > > different adapter power. > > > > > >

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

2020-08-02 Thread Greg KH
On Sun, Aug 02, 2020 at 02:00:15PM +0200, Pavel Machek wrote: > On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > > From: Qiwu Huang > > > > Reports the kind of quick charge type based on > > different adapter power. > > > > Signed-off-by: Qiwu Huang > > --- > >

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

2020-08-02 Thread Pavel Machek
On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > From: Qiwu Huang > > Reports the kind of quick charge type based on > different adapter power. > > Signed-off-by: Qiwu Huang > --- > Documentation/ABI/testing/sysfs-class-power | 21 + >

[PATCH v4 1/4] power: supply: core: add quick charge type property

2020-07-19 Thread Qiwu Huang
From: Qiwu Huang Reports the kind of quick charge type based on different adapter power. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 21 + drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h| 10