Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-13 Thread Matthias Kaehlcke
El Mon, Sep 12, 2016 at 06:18:31PM -0700 Matthias Kaehlcke ha dit: > El Tue, Sep 13, 2016 at 12:57:58AM +0100 Mark Brown ha dit: > > > On Mon, Sep 12, 2016 at 04:18:51PM -0700, Matthias Kaehlcke wrote: > > > El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit: > > > > On Tue, Sep 06, 2016

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-13 Thread Matthias Kaehlcke
El Mon, Sep 12, 2016 at 06:18:31PM -0700 Matthias Kaehlcke ha dit: > El Tue, Sep 13, 2016 at 12:57:58AM +0100 Mark Brown ha dit: > > > On Mon, Sep 12, 2016 at 04:18:51PM -0700, Matthias Kaehlcke wrote: > > > El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit: > > > > On Tue, Sep 06, 2016

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-12 Thread Matthias Kaehlcke
El Tue, Sep 13, 2016 at 12:57:58AM +0100 Mark Brown ha dit: > On Mon, Sep 12, 2016 at 04:18:51PM -0700, Matthias Kaehlcke wrote: > > El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit: > > > On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote: > > > > > - /* Call

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-12 Thread Matthias Kaehlcke
El Tue, Sep 13, 2016 at 12:57:58AM +0100 Mark Brown ha dit: > On Mon, Sep 12, 2016 at 04:18:51PM -0700, Matthias Kaehlcke wrote: > > El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit: > > > On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote: > > > > > - /* Call

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-12 Thread Mark Brown
On Mon, Sep 12, 2016 at 04:18:51PM -0700, Matthias Kaehlcke wrote: > El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit: > > On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote: > > > - /* Call set_voltage_time_sel if successfully obtained old_selector */ > > > - if (ret ==

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-12 Thread Mark Brown
On Mon, Sep 12, 2016 at 04:18:51PM -0700, Matthias Kaehlcke wrote: > El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit: > > On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote: > > > - /* Call set_voltage_time_sel if successfully obtained old_selector */ > > > - if (ret ==

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-12 Thread Matthias Kaehlcke
Hi Mark, thanks for your review, please find some comments below. El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit: > On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote: > > Whatever you're using to send these is not threading things as expected > and is adding a

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-12 Thread Matthias Kaehlcke
Hi Mark, thanks for your review, please find some comments below. El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit: > On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote: > > Whatever you're using to send these is not threading things as expected > and is adding a

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-12 Thread Mark Brown
On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote: Whatever you're using to send these is not threading things as expected and is adding a random HTML segment to the end of the e-mails - you probably want to look at this. If you're trying to use gmail via the web interface you

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-12 Thread Mark Brown
On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote: Whatever you're using to send these is not threading things as expected and is adding a random HTML segment to the end of the e-mails - you probably want to look at this. If you're trying to use gmail via the web interface you

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-06 Thread Mark Brown
On Tue, Sep 06, 2016 at 11:40:54PM +0100, Mark Brown wrote: > On Tue, Sep 06, 2016 at 02:01:25PM -0700, Matthias Kaehlcke wrote: > > The new op is analogous to set_voltage_time_sel. It can be used by > > regulators that don't have a table of discrete voltages. The function > I've only got patch 1

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-06 Thread Mark Brown
On Tue, Sep 06, 2016 at 11:40:54PM +0100, Mark Brown wrote: > On Tue, Sep 06, 2016 at 02:01:25PM -0700, Matthias Kaehlcke wrote: > > The new op is analogous to set_voltage_time_sel. It can be used by > > regulators that don't have a table of discrete voltages. The function > I've only got patch 1

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-06 Thread Mark Brown
On Tue, Sep 06, 2016 at 02:01:25PM -0700, Matthias Kaehlcke wrote: > The new op is analogous to set_voltage_time_sel. It can be used by > regulators that don't have a table of discrete voltages. The function I've only got patch 1 in this series, what's going on here? signature.asc Description:

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-06 Thread Mark Brown
On Tue, Sep 06, 2016 at 02:01:25PM -0700, Matthias Kaehlcke wrote: > The new op is analogous to set_voltage_time_sel. It can be used by > regulators that don't have a table of discrete voltages. The function I've only got patch 1 in this series, what's going on here? signature.asc Description:

[PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-06 Thread Matthias Kaehlcke
The new op is analogous to set_voltage_time_sel. It can be used by regulators that don't have a table of discrete voltages. The function returns the time for the regulator voltage output voltage to stabilize after being set to a new value, in microseconds. The actual calculation of the

[PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-06 Thread Matthias Kaehlcke
The new op is analogous to set_voltage_time_sel. It can be used by regulators that don't have a table of discrete voltages. The function returns the time for the regulator voltage output voltage to stabilize after being set to a new value, in microseconds. The actual calculation of the