Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-23 Thread Nishad Kamdar
On Wed, Aug 22, 2018 at 02:38:44PM +0300, Dan Carpenter wrote: > On Wed, Aug 22, 2018 at 04:40:56PM +0530, Nishad Kamdar wrote: > > On Wed, Aug 22, 2018 at 12:09:36PM +0300, Dan Carpenter wrote: > > > On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > > > > This patch fixes the debug

Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-23 Thread Nishad Kamdar
On Wed, Aug 22, 2018 at 02:38:44PM +0300, Dan Carpenter wrote: > On Wed, Aug 22, 2018 at 04:40:56PM +0530, Nishad Kamdar wrote: > > On Wed, Aug 22, 2018 at 12:09:36PM +0300, Dan Carpenter wrote: > > > On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > > > > This patch fixes the debug

Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-23 Thread Nishad Kamdar
On Wed, Aug 22, 2018 at 01:26:41PM +0200, Greg Kroah-Hartman wrote: > On Wed, Aug 22, 2018 at 04:40:56PM +0530, Nishad Kamdar wrote: > > On Wed, Aug 22, 2018 at 12:09:36PM +0300, Dan Carpenter wrote: > > > On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > > > > This patch fixes the

Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-23 Thread Nishad Kamdar
On Wed, Aug 22, 2018 at 01:26:41PM +0200, Greg Kroah-Hartman wrote: > On Wed, Aug 22, 2018 at 04:40:56PM +0530, Nishad Kamdar wrote: > > On Wed, Aug 22, 2018 at 12:09:36PM +0300, Dan Carpenter wrote: > > > On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > > > > This patch fixes the

Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-22 Thread Dan Carpenter
On Wed, Aug 22, 2018 at 04:40:56PM +0530, Nishad Kamdar wrote: > On Wed, Aug 22, 2018 at 12:09:36PM +0300, Dan Carpenter wrote: > > On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > > > This patch fixes the debug macro N_MSG. Replaces printk with > > > dev_ without __func__ or

Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-22 Thread Dan Carpenter
On Wed, Aug 22, 2018 at 04:40:56PM +0530, Nishad Kamdar wrote: > On Wed, Aug 22, 2018 at 12:09:36PM +0300, Dan Carpenter wrote: > > On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > > > This patch fixes the debug macro N_MSG. Replaces printk with > > > dev_ without __func__ or

Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-22 Thread Greg Kroah-Hartman
On Wed, Aug 22, 2018 at 04:40:56PM +0530, Nishad Kamdar wrote: > On Wed, Aug 22, 2018 at 12:09:36PM +0300, Dan Carpenter wrote: > > On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > > > This patch fixes the debug macro N_MSG. Replaces printk with > > > dev_ without __func__ or

Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-22 Thread Greg Kroah-Hartman
On Wed, Aug 22, 2018 at 04:40:56PM +0530, Nishad Kamdar wrote: > On Wed, Aug 22, 2018 at 12:09:36PM +0300, Dan Carpenter wrote: > > On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > > > This patch fixes the debug macro N_MSG. Replaces printk with > > > dev_ without __func__ or

Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-22 Thread Nishad Kamdar
On Wed, Aug 22, 2018 at 12:09:36PM +0300, Dan Carpenter wrote: > On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > > This patch fixes the debug macro N_MSG. Replaces printk with > > dev_ without __func__ or __LINE__ or current->comm and > > current->pid. Removes the do {} while(0)

Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-22 Thread Nishad Kamdar
On Wed, Aug 22, 2018 at 12:09:36PM +0300, Dan Carpenter wrote: > On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > > This patch fixes the debug macro N_MSG. Replaces printk with > > dev_ without __func__ or __LINE__ or current->comm and > > current->pid. Removes the do {} while(0)

Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-22 Thread Dan Carpenter
On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > This patch fixes the debug macro N_MSG. Replaces printk with > dev_ without __func__ or __LINE__ or current->comm and > current->pid. Removes the do {} while(0) loop for the single > statement macro. Issue found by checkpatch. > >

Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-22 Thread Dan Carpenter
On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > This patch fixes the debug macro N_MSG. Replaces printk with > dev_ without __func__ or __LINE__ or current->comm and > current->pid. Removes the do {} while(0) loop for the single > statement macro. Issue found by checkpatch. > >

[PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-22 Thread Nishad Kamdar
This patch fixes the debug macro N_MSG. Replaces printk with dev_ without __func__ or __LINE__ or current->comm and current->pid. Removes the do {} while(0) loop for the single statement macro. Issue found by checkpatch. Signed-off-by: Nishad Kamdar --- drivers/staging/mt7621-mmc/dbg.h | 11

[PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG

2018-08-22 Thread Nishad Kamdar
This patch fixes the debug macro N_MSG. Replaces printk with dev_ without __func__ or __LINE__ or current->comm and current->pid. Removes the do {} while(0) loop for the single statement macro. Issue found by checkpatch. Signed-off-by: Nishad Kamdar --- drivers/staging/mt7621-mmc/dbg.h | 11