Re: [PATCH v4 1/5] i2c:ocores: stop transfer on timeout

2019-02-11 Thread Wolfram Sang
> Could you drop these patches and wait for a new version? I don't > think you have pushed it out yet? So it won't be a visible rebase. Yes, I can do that. When resending, just make sure you include the fixes I mentioned when applying. Thanks! signature.asc Description: PGP signature

Re: [PATCH v4 1/5] i2c:ocores: stop transfer on timeout

2019-02-11 Thread Federico Vaga
On Monday, February 11, 2019 3:01:38 PM CET Andrew Lunn wrote: > > Applied to for-next, thanks! > > Hi Wolfram > > Could you drop these patches and wait for a new version? I don't > think you have pushed it out yet? So it won't be a visible rebase. I will wait to send v5: full patch set, or jus

Re: [PATCH v4 1/5] i2c:ocores: stop transfer on timeout

2019-02-11 Thread Andrew Lunn
> Applied to for-next, thanks! Hi Wolfram Could you drop these patches and wait for a new version? I don't think you have pushed it out yet? So it won't be a visible rebase. Thanks Andrew

Re: [PATCH v4 1/5] i2c:ocores: stop transfer on timeout

2019-02-11 Thread Federico Vaga
On Monday, February 11, 2019 11:44:46 AM CET Peter Rosin wrote: > On 2019-02-11 09:31, Federico Vaga wrote: > > > Detecting a timeout is ok, but we also need to assert a STOP command on > > the bus in order to prevent it from generating interrupts when there are > > no on going transfers. > > > >

Re: [PATCH v4 1/5] i2c:ocores: stop transfer on timeout

2019-02-11 Thread Peter Rosin
On 2019-02-11 09:31, Federico Vaga wrote: > Detecting a timeout is ok, but we also need to assert a STOP command on > the bus in order to prevent it from generating interrupts when there are > no on going transfers. > > Example: very long transmission. > > 1. ocores_xfer: START a transfer > 2. oc

Re: [PATCH v4 1/5] i2c:ocores: stop transfer on timeout

2019-02-11 Thread Wolfram Sang
On Mon, Feb 11, 2019 at 09:31:18AM +0100, Federico Vaga wrote: > Detecting a timeout is ok, but we also need to assert a STOP command on > the bus in order to prevent it from generating interrupts when there are > no on going transfers. > > Example: very long transmission. > > 1. ocores_xfer: STA

[PATCH v4 1/5] i2c:ocores: stop transfer on timeout

2019-02-11 Thread Federico Vaga
Detecting a timeout is ok, but we also need to assert a STOP command on the bus in order to prevent it from generating interrupts when there are no on going transfers. Example: very long transmission. 1. ocores_xfer: START a transfer 2. ocores_isr : handle byte by byte the transfer 3. ocores_xfer