Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c

2021-04-20 Thread Michal Hocko
On Mon 19-04-21 17:11:37, Johannes Weiner wrote: > On Mon, Apr 19, 2021 at 01:26:29PM -0400, Waiman Long wrote: [...] > - the soft limit tree and soft limit reclaim > > - the threshold and oom event notification stuff > > - the charge moving code > > - remaining v1 interface files, as well as th

Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c

2021-04-19 Thread Waiman Long
On 4/19/21 5:11 PM, Johannes Weiner wrote: BTW, have you ever thought of moving the cgroup-v1 specific functions out into a separate memcontrol-v1.c file just like kernel/cgroup/cgroup-v1.c? I thought of that before, but memcontrol.c is a frequently changed file and so a bit hard to do. I hav

Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c

2021-04-19 Thread Johannes Weiner
On Mon, Apr 19, 2021 at 01:26:29PM -0400, Waiman Long wrote: > On 4/19/21 1:19 PM, Waiman Long wrote: > > On 4/19/21 1:13 PM, Johannes Weiner wrote: > > > The CONFIG_MEMCG_KMEM has become sort of useless now. It used to be > > > configurable, but now it just means CONFIG_MEMCG && !CONFIG_SLOB. And

Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c

2021-04-19 Thread Waiman Long
On 4/19/21 1:19 PM, Waiman Long wrote: On 4/19/21 1:13 PM, Johannes Weiner wrote: On Mon, Apr 19, 2021 at 12:18:29PM -0400, Waiman Long wrote: On 4/19/21 11:21 AM, Waiman Long wrote: On 4/19/21 11:14 AM, Johannes Weiner wrote: On Sun, Apr 18, 2021 at 08:00:28PM -0400, Waiman Long wrote: The

Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c

2021-04-19 Thread Waiman Long
On 4/19/21 1:13 PM, Johannes Weiner wrote: On Mon, Apr 19, 2021 at 12:18:29PM -0400, Waiman Long wrote: On 4/19/21 11:21 AM, Waiman Long wrote: On 4/19/21 11:14 AM, Johannes Weiner wrote: On Sun, Apr 18, 2021 at 08:00:28PM -0400, Waiman Long wrote: The mod_objcg_state() function is moved from

Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c

2021-04-19 Thread Johannes Weiner
On Mon, Apr 19, 2021 at 12:18:29PM -0400, Waiman Long wrote: > On 4/19/21 11:21 AM, Waiman Long wrote: > > On 4/19/21 11:14 AM, Johannes Weiner wrote: > > > On Sun, Apr 18, 2021 at 08:00:28PM -0400, Waiman Long wrote: > > > > The mod_objcg_state() function is moved from mm/slab.h to > > > > mm/memc

Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c

2021-04-19 Thread Waiman Long
On 4/19/21 11:21 AM, Waiman Long wrote: On 4/19/21 11:14 AM, Johannes Weiner wrote: On Sun, Apr 18, 2021 at 08:00:28PM -0400, Waiman Long wrote: The mod_objcg_state() function is moved from mm/slab.h to mm/memcontrol.c so that further optimization can be done to it in later patches without exp

Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c

2021-04-19 Thread Shakeel Butt
On Sun, Apr 18, 2021 at 5:00 PM Waiman Long wrote: > > The mod_objcg_state() function is moved from mm/slab.h to mm/memcontrol.c > so that further optimization can be done to it in later patches without > exposing unnecessary details to other mm components. > > Signed-off-by: Waiman Long Reviewe

Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c

2021-04-19 Thread Waiman Long
On 4/19/21 11:14 AM, Johannes Weiner wrote: On Sun, Apr 18, 2021 at 08:00:28PM -0400, Waiman Long wrote: The mod_objcg_state() function is moved from mm/slab.h to mm/memcontrol.c so that further optimization can be done to it in later patches without exposing unnecessary details to other mm comp

Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c

2021-04-19 Thread Johannes Weiner
On Sun, Apr 18, 2021 at 08:00:28PM -0400, Waiman Long wrote: > The mod_objcg_state() function is moved from mm/slab.h to mm/memcontrol.c > so that further optimization can be done to it in later patches without > exposing unnecessary details to other mm components. > > Signed-off-by: Waiman Long

[PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c

2021-04-18 Thread Waiman Long
The mod_objcg_state() function is moved from mm/slab.h to mm/memcontrol.c so that further optimization can be done to it in later patches without exposing unnecessary details to other mm components. Signed-off-by: Waiman Long --- mm/memcontrol.c | 13 + mm/slab.h | 16 ++---