RE: [PATCH v4 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2018-02-06 Thread Adam Thomson
On 30 January 2018 12:22, Heikki Krogerus wrote: > On Tue, Jan 02, 2018 at 03:50:49PM +, Adam Thomson wrote: > > This commit adds definitions for PD Rev 3.0 messages, including > > APDO PPS and extended message support for TCPM. > > > > Signed-off-by: Adam Thomson

RE: [PATCH v4 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2018-02-06 Thread Adam Thomson
On 30 January 2018 12:22, Heikki Krogerus wrote: > On Tue, Jan 02, 2018 at 03:50:49PM +, Adam Thomson wrote: > > This commit adds definitions for PD Rev 3.0 messages, including > > APDO PPS and extended message support for TCPM. > > > > Signed-off-by: Adam Thomson > > Just one nitpick. I

Re: [PATCH v4 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2018-01-30 Thread Heikki Krogerus
On Tue, Jan 02, 2018 at 03:50:49PM +, Adam Thomson wrote: > This commit adds definitions for PD Rev 3.0 messages, including > APDO PPS and extended message support for TCPM. > > Signed-off-by: Adam Thomson Just one nitpick. I noticed that you are

Re: [PATCH v4 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2018-01-30 Thread Heikki Krogerus
On Tue, Jan 02, 2018 at 03:50:49PM +, Adam Thomson wrote: > This commit adds definitions for PD Rev 3.0 messages, including > APDO PPS and extended message support for TCPM. > > Signed-off-by: Adam Thomson Just one nitpick. I noticed that you are exceeding the 80 character limit per line in

[PATCH v4 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2018-01-02 Thread Adam Thomson
This commit adds definitions for PD Rev 3.0 messages, including APDO PPS and extended message support for TCPM. Signed-off-by: Adam Thomson --- include/linux/usb/pd.h | 185 ++--- 1 file changed, 174 insertions(+),

[PATCH v4 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2018-01-02 Thread Adam Thomson
This commit adds definitions for PD Rev 3.0 messages, including APDO PPS and extended message support for TCPM. Signed-off-by: Adam Thomson --- include/linux/usb/pd.h | 185 ++--- 1 file changed, 174 insertions(+), 11 deletions(-) diff --git