Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs

2013-11-29 Thread Dave Young
On 11/27/13 at 11:20am, Matt Fleming wrote: > On Tue, 26 Nov, at 01:57:55PM, Dave Young wrote: > > +Users: > > + Kexec Mailing List > > "Kexec" please. Will change > > > +static ssize_t version_show(struct kobject *kobj, > > + struct kobj_attribute

Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs

2013-11-29 Thread Dave Young
On 11/27/13 at 03:56pm, Borislav Petkov wrote: > On Tue, Nov 26, 2013 at 01:57:55PM +0800, Dave Young wrote: > > kexec-tools use boot_params for getting the 1st kernel hardware_subarch, > > the kexec kernel efi runtime support also need read the old efi_info from > > boot_params. Currently it

Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs

2013-11-29 Thread Dave Young
On 11/27/13 at 03:56pm, Borislav Petkov wrote: On Tue, Nov 26, 2013 at 01:57:55PM +0800, Dave Young wrote: kexec-tools use boot_params for getting the 1st kernel hardware_subarch, the kexec kernel efi runtime support also need read the old efi_info from boot_params. Currently it exists in

Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs

2013-11-29 Thread Dave Young
On 11/27/13 at 11:20am, Matt Fleming wrote: On Tue, 26 Nov, at 01:57:55PM, Dave Young wrote: +Users: + Kexec Mailing List ke...@lists.infradead.org Kexec please. Will change +static ssize_t version_show(struct kobject *kobj, + struct

Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs

2013-11-27 Thread Borislav Petkov
On Tue, Nov 26, 2013 at 01:57:55PM +0800, Dave Young wrote: > kexec-tools use boot_params for getting the 1st kernel hardware_subarch, > the kexec kernel efi runtime support also need read the old efi_info from > boot_params. Currently it exists in debugfs which is not a good place for > such

Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs

2013-11-27 Thread Matt Fleming
On Tue, 26 Nov, at 01:57:55PM, Dave Young wrote: > +Users: > + Kexec Mailing List "Kexec" please. > +static ssize_t version_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) This is pretty strange indentation. Usually we

Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs

2013-11-27 Thread Matt Fleming
On Tue, 26 Nov, at 01:57:55PM, Dave Young wrote: +Users: + Kexec Mailing List ke...@lists.infradead.org Kexec please. +static ssize_t version_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) This is pretty strange

Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs

2013-11-27 Thread Borislav Petkov
On Tue, Nov 26, 2013 at 01:57:55PM +0800, Dave Young wrote: kexec-tools use boot_params for getting the 1st kernel hardware_subarch, the kexec kernel efi runtime support also need read the old efi_info from boot_params. Currently it exists in debugfs which is not a good place for such

[PATCH v4 10/12] x86: export x86 boot_params to sysfs

2013-11-25 Thread Dave Young
kexec-tools use boot_params for getting the 1st kernel hardware_subarch, the kexec kernel efi runtime support also need read the old efi_info from boot_params. Currently it exists in debugfs which is not a good place for such infomation. Per HPA, we should avoid of "sploit debugfs". In this patch

[PATCH v4 10/12] x86: export x86 boot_params to sysfs

2013-11-25 Thread Dave Young
kexec-tools use boot_params for getting the 1st kernel hardware_subarch, the kexec kernel efi runtime support also need read the old efi_info from boot_params. Currently it exists in debugfs which is not a good place for such infomation. Per HPA, we should avoid of sploit debugfs. In this patch