Re: [PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline

2013-11-29 Thread Borislav Petkov
On Fri, Nov 29, 2013 at 04:35:52PM +0800, Dave Young wrote: > Is below changes ok to you? Almost perfect! Just a micro-nitpick below: > Currently e820_reserve_setup_data is called before parsing early params, > it works in normal case. But for memmap=exactmap, the final memory ranges > are

Re: [PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline

2013-11-29 Thread Dave Young
On 11/27/13 at 04:07pm, Borislav Petkov wrote: > On Tue, Nov 26, 2013 at 01:57:56PM +0800, Dave Young wrote: > > Kdump kernel using memmap=exactmap, move e820_reserve_setup_data after > > parsing early params so they can be set reserved finally. Or kdump kernel > > will warn about ioremap a normal

Re: [PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline

2013-11-29 Thread Dave Young
On 11/27/13 at 04:07pm, Borislav Petkov wrote: On Tue, Nov 26, 2013 at 01:57:56PM +0800, Dave Young wrote: Kdump kernel using memmap=exactmap, move e820_reserve_setup_data after parsing early params so they can be set reserved finally. Or kdump kernel will warn about ioremap a normal ram

Re: [PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline

2013-11-29 Thread Borislav Petkov
On Fri, Nov 29, 2013 at 04:35:52PM +0800, Dave Young wrote: Is below changes ok to you? Almost perfect! Just a micro-nitpick below: Currently e820_reserve_setup_data is called before parsing early params, it works in normal case. But for memmap=exactmap, the final memory ranges are created

Re: [PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline

2013-11-27 Thread Borislav Petkov
On Tue, Nov 26, 2013 at 01:57:56PM +0800, Dave Young wrote: > Kdump kernel using memmap=exactmap, move e820_reserve_setup_data after > parsing early params so they can be set reserved finally. Or kdump kernel > will warn about ioremap a normal ram range. I had to stare for a while at this commit

Re: [PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline

2013-11-27 Thread Borislav Petkov
On Tue, Nov 26, 2013 at 01:57:56PM +0800, Dave Young wrote: Kdump kernel using memmap=exactmap, move e820_reserve_setup_data after parsing early params so they can be set reserved finally. Or kdump kernel will warn about ioremap a normal ram range. I had to stare for a while at this commit

[PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline

2013-11-25 Thread Dave Young
Kdump kernel using memmap=exactmap, move e820_reserve_setup_data after parsing early params so they can be set reserved finally. Or kdump kernel will warn about ioremap a normal ram range. Signed-off-by: Dave Young --- arch/x86/kernel/setup.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline

2013-11-25 Thread Dave Young
Kdump kernel using memmap=exactmap, move e820_reserve_setup_data after parsing early params so they can be set reserved finally. Or kdump kernel will warn about ioremap a normal ram range. Signed-off-by: Dave Young dyo...@redhat.com --- arch/x86/kernel/setup.c | 4 ++-- 1 file changed, 2