Re: [PATCH v4 12/16] block: sed-opal: unify retrieval of table columns

2019-02-08 Thread Derrick, Jonathan
Looks good Reviewed-by: Jon Derrick On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote: > From: Jonas Rabenstein > > Instead of having multiple places defining the same argument list to get > a specific column of a sed-opal table, provide a generic version and > call it from those

Re: [PATCH v4 12/16] block: sed-opal: unify retrieval of table columns

2019-02-04 Thread Christoph Hellwig
> +++ b/block/opal_proto.h > @@ -170,6 +170,8 @@ enum opal_token { > OPAL_READLOCKED = 0x07, > OPAL_WRITELOCKED = 0x08, > OPAL_ACTIVEKEY = 0x0A, > + /* lockingsp table */ > + OPAL_LIFECYCLE = 0x06, Adding a name for the colum seems independent of the refactoring, and

[PATCH v4 12/16] block: sed-opal: unify retrieval of table columns

2019-02-01 Thread David Kozub
From: Jonas Rabenstein Instead of having multiple places defining the same argument list to get a specific column of a sed-opal table, provide a generic version and call it from those functions. Signed-off-by: Jonas Rabenstein Reviewed-by: Scott Bauer --- block/opal_proto.h | 2 +