Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-07 Thread Rhyland Klein
On 5/7/2015 6:39 AM, Jim Lin wrote: > On 05/05/2015 12:37 AM, Rhyland Klein wrote: >> diff --git a/drivers/clk/tegra/clk-tegra210.c >> b/drivers/clk/tegra/clk-tegra210.c >> new file mode 100644 >> index ..07382a473e22 >> --- /dev/null >> +++ b/drivers/clk/tegra/clk-tegra210.c >> @@

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-07 Thread Thierry Reding
On Mon, May 04, 2015 at 12:37:39PM -0400, Rhyland Klein wrote: [...] > diff --git a/drivers/clk/tegra/clk-tegra210.c > b/drivers/clk/tegra/clk-tegra210.c [...] > +static void __init tegra210_clock_init(struct device_node *np) > +{ [...] > + tegra_fixed_clk_init(tegra210_clks); > +

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-07 Thread Thierry Reding
On Wed, May 06, 2015 at 01:21:06PM -0400, Rhyland Klein wrote: > On 5/6/2015 10:51 AM, Thierry Reding wrote: > > * PGP Signed by an unknown key > > > > On Mon, May 04, 2015 at 12:37:39PM -0400, Rhyland Klein wrote: > > [...] > >> diff --git a/drivers/clk/tegra/clk-tegra210.c > >>

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-07 Thread Jim Lin
On 05/05/2015 12:37 AM, Rhyland Klein wrote: diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c new file mode 100644 index ..07382a473e22 --- /dev/null +++ b/drivers/clk/tegra/clk-tegra210.c @@ -0,0 +1,2761 @@ +/* + * Copyright (c) 2012-2014 NVIDIA

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-07 Thread Thierry Reding
On Wed, May 06, 2015 at 01:21:06PM -0400, Rhyland Klein wrote: On 5/6/2015 10:51 AM, Thierry Reding wrote: * PGP Signed by an unknown key On Mon, May 04, 2015 at 12:37:39PM -0400, Rhyland Klein wrote: [...] diff --git a/drivers/clk/tegra/clk-tegra210.c

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-07 Thread Rhyland Klein
On 5/7/2015 6:39 AM, Jim Lin wrote: On 05/05/2015 12:37 AM, Rhyland Klein wrote: diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c new file mode 100644 index ..07382a473e22 --- /dev/null +++ b/drivers/clk/tegra/clk-tegra210.c @@ -0,0 +1,2761 @@

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-07 Thread Thierry Reding
On Mon, May 04, 2015 at 12:37:39PM -0400, Rhyland Klein wrote: [...] diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c [...] +static void __init tegra210_clock_init(struct device_node *np) +{ [...] + tegra_fixed_clk_init(tegra210_clks); +

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-07 Thread Jim Lin
On 05/05/2015 12:37 AM, Rhyland Klein wrote: diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c new file mode 100644 index ..07382a473e22 --- /dev/null +++ b/drivers/clk/tegra/clk-tegra210.c @@ -0,0 +1,2761 @@ +/* + * Copyright (c) 2012-2014 NVIDIA

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-06 Thread Rhyland Klein
On 5/6/2015 10:51 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, May 04, 2015 at 12:37:39PM -0400, Rhyland Klein wrote: > [...] >> diff --git a/drivers/clk/tegra/clk-tegra210.c >> b/drivers/clk/tegra/clk-tegra210.c > [...] >> +static struct div_nmp plld_nmp = { >> +

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-06 Thread Rhyland Klein
On 5/6/2015 10:51 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, May 04, 2015 at 12:37:39PM -0400, Rhyland Klein wrote: > [...] >> diff --git a/drivers/clk/tegra/clk-tegra210.c >> b/drivers/clk/tegra/clk-tegra210.c > [...] >> +static struct div_nmp plld_nmp = { >> +

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-06 Thread Thierry Reding
On Mon, May 04, 2015 at 12:37:39PM -0400, Rhyland Klein wrote: [...] > diff --git a/drivers/clk/tegra/clk-tegra210.c > b/drivers/clk/tegra/clk-tegra210.c [...] > +static struct div_nmp plld_nmp = { > + .divm_shift = 0, > + .divm_width = 8, > + .divn_shift = 11, > + .divn_width =

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-06 Thread Thierry Reding
On Mon, May 04, 2015 at 12:37:39PM -0400, Rhyland Klein wrote: [...] diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c [...] +static struct div_nmp plld_nmp = { + .divm_shift = 0, + .divm_width = 8, + .divn_shift = 11, + .divn_width = 8, +

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-06 Thread Rhyland Klein
On 5/6/2015 10:51 AM, Thierry Reding wrote: * PGP Signed by an unknown key On Mon, May 04, 2015 at 12:37:39PM -0400, Rhyland Klein wrote: [...] diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c [...] +static struct div_nmp plld_nmp = { +.divm_shift =

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-06 Thread Rhyland Klein
On 5/6/2015 10:51 AM, Thierry Reding wrote: * PGP Signed by an unknown key On Mon, May 04, 2015 at 12:37:39PM -0400, Rhyland Klein wrote: [...] diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c [...] +static struct div_nmp plld_nmp = { +.divm_shift =

[PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-04 Thread Rhyland Klein
Implement clock support for Tegra210. Signed-off-by: Rhyland Klein --- v4: - Fixed checkpatch errors - Fixed pllx_dyn_ramp error (missing ->params) v3: - Fixed pll_u hierarchy. PLL_U has a vco output now, and out1 and out2 clocks which are used to generate 60M and 48M clocks. VCO is

[PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-04 Thread Rhyland Klein
Implement clock support for Tegra210. Signed-off-by: Rhyland Klein rkl...@nvidia.com --- v4: - Fixed checkpatch errors - Fixed pllx_dyn_ramp error (missing -params) v3: - Fixed pll_u hierarchy. PLL_U has a vco output now, and out1 and out2 clocks which are used to generate 60M and 48M