Re: [PATCH v4 2/2] CPU hotplug, stop-machine: Plug race-window that leads to "IPI-to-offline-CPU"

On 05/13/2014 09:27 PM, Frederic Weisbecker wrote: > On Tue, May 13, 2014 at 02:32:00PM +0530, Srivatsa S. Bhat wrote: >> >> kernel/stop_machine.c | 39 ++- >> 1 file changed, 34 insertions(+), 5 deletions(-) >> >> diff --git a/kernel/stop_machine.c

Re: [PATCH v4 2/2] CPU hotplug, stop-machine: Plug race-window that leads to IPI-to-offline-CPU

On 05/13/2014 09:27 PM, Frederic Weisbecker wrote: On Tue, May 13, 2014 at 02:32:00PM +0530, Srivatsa S. Bhat wrote: kernel/stop_machine.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/kernel/stop_machine.c

Re: [PATCH v4 2/2] CPU hotplug, stop-machine: Plug race-window that leads to "IPI-to-offline-CPU"

On Tue, May 13, 2014 at 02:32:00PM +0530, Srivatsa S. Bhat wrote: > > kernel/stop_machine.c | 39 ++- > 1 file changed, 34 insertions(+), 5 deletions(-) > > diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c > index 01fbae5..288f7fe 100644 > ---

[PATCH v4 2/2] CPU hotplug, stop-machine: Plug race-window that leads to "IPI-to-offline-CPU"

he duplicated amount is trivial and what's going on would be far > clearer. > But yeah, I agree that the expanded form is less cryptic and hence better for readability. How about the updated version below? Regards, Srivatsa S. Bhat --- From: Srivatsa S. Bhat [PATCH v4

[PATCH v4 2/2] CPU hotplug, stop-machine: Plug race-window that leads to IPI-to-offline-CPU

v4 2/2] CPU hotplug, stop-machine: Plug race-window that leads to IPI-to-offline-CPU During CPU offline, stop-machine is used to take control over all the online CPUs (via the per-cpu stopper thread) and then run take_cpu_down() on the CPU that is to be taken offline. But stop-machine itself has