Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-16 Thread rishabhb
On 2018-04-16 10:14, Evan Green wrote: On Fri, Apr 13, 2018 at 4:08 PM wrote: On 2018-04-12 15:02, Evan Green wrote: > Hi Rishabh, > > On Tue, Apr 10, 2018 at 1:09 PM Rishabh Bhatnagar > > wrote: > >> LLCC (Last Level Cache Controller)

Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-16 Thread rishabhb
On 2018-04-16 10:14, Evan Green wrote: On Fri, Apr 13, 2018 at 4:08 PM wrote: On 2018-04-12 15:02, Evan Green wrote: > Hi Rishabh, > > On Tue, Apr 10, 2018 at 1:09 PM Rishabh Bhatnagar > > wrote: > >> LLCC (Last Level Cache Controller) provides additional cache memory >> in the system. LLCC

Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-16 Thread saiprakash . ranjan
Hi Rishabh, +MODULE_DESCRIPTION("QTI sdm845 LLCC driver"); I think it should be QCOM or Qualcomm and not QTI + + desc = devm_kzalloc(dev, sizeof(struct llcc_slice_desc), GFP_KERNEL); Can use *desc instead +struct llcc_slice_desc *llcc_slice_getd(struct device *dev, const char

Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-16 Thread saiprakash . ranjan
Hi Rishabh, +MODULE_DESCRIPTION("QTI sdm845 LLCC driver"); I think it should be QCOM or Qualcomm and not QTI + + desc = devm_kzalloc(dev, sizeof(struct llcc_slice_desc), GFP_KERNEL); Can use *desc instead +struct llcc_slice_desc *llcc_slice_getd(struct device *dev, const char

Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-16 Thread Evan Green
On Fri, Apr 13, 2018 at 4:08 PM wrote: > On 2018-04-12 15:02, Evan Green wrote: > > Hi Rishabh, > > > > On Tue, Apr 10, 2018 at 1:09 PM Rishabh Bhatnagar > > > > wrote: > > > >> LLCC (Last Level Cache Controller) provides additional cache memory

Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-16 Thread Evan Green
On Fri, Apr 13, 2018 at 4:08 PM wrote: > On 2018-04-12 15:02, Evan Green wrote: > > Hi Rishabh, > > > > On Tue, Apr 10, 2018 at 1:09 PM Rishabh Bhatnagar > > > > wrote: > > > >> LLCC (Last Level Cache Controller) provides additional cache memory > >> in the system. LLCC is partitioned into

Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-13 Thread rishabhb
On 2018-04-12 15:02, Evan Green wrote: Hi Rishabh, On Tue, Apr 10, 2018 at 1:09 PM Rishabh Bhatnagar wrote: LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into multiple slices and each slice gets its own

Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-13 Thread rishabhb
On 2018-04-12 15:02, Evan Green wrote: Hi Rishabh, On Tue, Apr 10, 2018 at 1:09 PM Rishabh Bhatnagar wrote: LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into multiple slices and each slice gets its own priority, size, ID and other

Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-12 Thread Evan Green
Hi Rishabh, On Tue, Apr 10, 2018 at 1:09 PM Rishabh Bhatnagar wrote: > LLCC (Last Level Cache Controller) provides additional cache memory > in the system. LLCC is partitioned into multiple slices and each > slice gets its own priority, size, ID and other config

Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-12 Thread Evan Green
Hi Rishabh, On Tue, Apr 10, 2018 at 1:09 PM Rishabh Bhatnagar wrote: > LLCC (Last Level Cache Controller) provides additional cache memory > in the system. LLCC is partitioned into multiple slices and each > slice gets its own priority, size, ID and other config parameters. > LLCC driver

Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-10 Thread Jordan Crouse
On Tue, Apr 10, 2018 at 01:08:13PM -0700, Rishabh Bhatnagar wrote: > LLCC (Last Level Cache Controller) provides additional cache memory > in the system. LLCC is partitioned into multiple slices and each > slice gets its own priority, size, ID and other config parameters. > LLCC driver programs

Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-10 Thread Jordan Crouse
On Tue, Apr 10, 2018 at 01:08:13PM -0700, Rishabh Bhatnagar wrote: > LLCC (Last Level Cache Controller) provides additional cache memory > in the system. LLCC is partitioned into multiple slices and each > slice gets its own priority, size, ID and other config parameters. > LLCC driver programs

[PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-10 Thread Rishabh Bhatnagar
LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into multiple slices and each slice gets its own priority, size, ID and other config parameters. LLCC driver programs these parameters for each slice. Clients that are assigned to use LLCC need

[PATCH v4 2/2] drivers: soc: Add LLCC driver

2018-04-10 Thread Rishabh Bhatnagar
LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into multiple slices and each slice gets its own priority, size, ID and other config parameters. LLCC driver programs these parameters for each slice. Clients that are assigned to use LLCC need