Re: [PATCH v4 2/2] mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning

2019-03-29 Thread Faiz Abbas
Hi Adrian, On 28/03/19 1:43 PM, Adrian Hunter wrote: > On 27/03/19 1:47 PM, Faiz Abbas wrote: >> Hi Adrian, >> >> On 27/03/19 4:45 PM, Adrian Hunter wrote: >>> On 26/03/19 1:00 PM, Faiz Abbas wrote: commit 5b0d62108b46 ("mmc: sdhci-omap: Add platform specific reset callback") skips data

Re: [PATCH v4 2/2] mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning

2019-03-28 Thread Adrian Hunter
On 27/03/19 1:47 PM, Faiz Abbas wrote: > Hi Adrian, > > On 27/03/19 4:45 PM, Adrian Hunter wrote: >> On 26/03/19 1:00 PM, Faiz Abbas wrote: >>> commit 5b0d62108b46 ("mmc: sdhci-omap: Add platform specific reset >>> callback") skips data resets during tuning operation. Because of this, >>> a data

Re: [PATCH v4 2/2] mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning

2019-03-27 Thread Faiz Abbas
Hi Adrian, On 27/03/19 4:45 PM, Adrian Hunter wrote: > On 26/03/19 1:00 PM, Faiz Abbas wrote: >> commit 5b0d62108b46 ("mmc: sdhci-omap: Add platform specific reset >> callback") skips data resets during tuning operation. Because of this, >> a data error or data finish interrupt might still arrive

Re: [PATCH v4 2/2] mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning

2019-03-27 Thread Adrian Hunter
On 26/03/19 1:00 PM, Faiz Abbas wrote: > commit 5b0d62108b46 ("mmc: sdhci-omap: Add platform specific reset > callback") skips data resets during tuning operation. Because of this, > a data error or data finish interrupt might still arrive after a command > error has been handled and the mrq

[PATCH v4 2/2] mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning

2019-03-26 Thread Faiz Abbas
commit 5b0d62108b46 ("mmc: sdhci-omap: Add platform specific reset callback") skips data resets during tuning operation. Because of this, a data error or data finish interrupt might still arrive after a command error has been handled and the mrq ended. This ends up with a "mmc0: Got data interrupt