Re: [EXTERNAL] Re: [PATCH v4 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

2020-10-01 Thread Ricardo Rivera-Matos
Sebastian On 9/30/20 6:47 PM, Sebastian Reichel wrote: Hi, You are leaking some resources, otherwise LGTM. ACK On Wed, Sep 23, 2020 at 10:24:16AM -0500, Ricardo Rivera-Matos wrote: [...] +static int bq256xx_hw_init(struct bq256xx_device *bq) +{ + struct power_supply_battery_info

Re: [PATCH v4 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

2020-09-30 Thread Sebastian Reichel
Hi, You are leaking some resources, otherwise LGTM. On Wed, Sep 23, 2020 at 10:24:16AM -0500, Ricardo Rivera-Matos wrote: > [...] > +static int bq256xx_hw_init(struct bq256xx_device *bq) > +{ > + struct power_supply_battery_info bat_info = { }; > + int wd_reg_val = BQ256XX_WATCHDOG_DIS;

[PATCH v4 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

2020-09-23 Thread Ricardo Rivera-Matos
The BQ256XX family of devices are highly integrated buck chargers for single cell batteries. Signed-off-by: Ricardo Rivera-Matos --- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile |1 + drivers/power/supply/bq256xx_charger.c | 1769