Re: [Outreachy kernel] Re: [PATCH v4 2/2] staging: media: zoran: add BIT() macro and align code

2021-04-15 Thread Julia Lawall
> > > +#define ZR36057_JMC_JPG_EXP_MODE (0 << 29) > > > +#define ZR36057_JMC_JPG_CMP_MODE BIT(29) > > > +#define ZR36057_JMC_MJPG_EXP_MODE(2 << 29) > > > +#define ZR36057_JMC_MJPG_CMP_MODE(3 << 29) > > Same as above. Please change back

Re: [PATCH v4 2/2] staging: media: zoran: add BIT() macro and align code

2021-04-15 Thread Mitali Borkar
On Wed, Apr 14, 2021 at 12:38:41PM +0200, z...@gentoo.org wrote: > Am 13.04.21 um 21:50 schrieb Mitali Borkar: > > Added #include and replaced bit shifts by BIT() macro. > > This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_* > > bitmasks. > > Use of macro is better and

Re: [PATCH v4 2/2] staging: media: zoran: add BIT() macro and align code

2021-04-14 Thread zzam
Am 13.04.21 um 21:50 schrieb Mitali Borkar: Added #include and replaced bit shifts by BIT() macro. This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_* bitmasks. Use of macro is better and neater. It maintains consistency. Removed comments from the same line and added them

[PATCH v4 2/2] staging: media: zoran: add BIT() macro and align code

2021-04-13 Thread Mitali Borkar
Added #include and replaced bit shifts by BIT() macro. This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_* bitmasks. Use of macro is better and neater. It maintains consistency. Removed comments from the same line and added them to new line above the blocks, aligned