Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

Masami, Your patch works, thanks! However, I felt we could refactor and reuse some of the code across kprobes.c for this purpose. Can you please see if the below patch is fine? Thanks, Naveen -- trace/kprobes: fix check for kretprobe offset within function entry perf specifies an offset from

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

Masami, Your patch works, thanks! However, I felt we could refactor and reuse some of the code across kprobes.c for this purpose. Can you please see if the below patch is fine? Thanks, Naveen -- trace/kprobes: fix check for kretprobe offset within function entry perf specifies an offset from

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Mon, 6 Mar 2017 20:34:10 +0530 "Naveen N. Rao" wrote: > On 2017/03/04 09:49AM, Masami Hiramatsu wrote: > > On Thu, 2 Mar 2017 23:25:06 +0530 > > "Naveen N. Rao" wrote: > > > > > We indicate support for accepting sym+offset

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Mon, 6 Mar 2017 20:34:10 +0530 "Naveen N. Rao" wrote: > On 2017/03/04 09:49AM, Masami Hiramatsu wrote: > > On Thu, 2 Mar 2017 23:25:06 +0530 > > "Naveen N. Rao" wrote: > > > > > We indicate support for accepting sym+offset with kretprobes through a > > > line in ftrace README. Parse the

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Mon, 6 Mar 2017 23:19:09 +0530 "Naveen N. Rao" wrote: > Masami, > Your patch works, thanks! However, I felt we could refactor and reuse > some of the code across kprobes.c for this purpose. Can you please see > if the below patch is fine? OK, looks good to

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Mon, 6 Mar 2017 23:19:09 +0530 "Naveen N. Rao" wrote: > Masami, > Your patch works, thanks! However, I felt we could refactor and reuse > some of the code across kprobes.c for this purpose. Can you please see > if the below patch is fine? OK, looks good to me:) Acked-by: Masami Hiramatsu

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On 2017/03/04 01:34PM, Masami Hiramatsu wrote: > On Sat, 4 Mar 2017 11:35:51 +0900 > Masami Hiramatsu wrote: > > > On Sat, 4 Mar 2017 09:49:11 +0900 > > Masami Hiramatsu wrote: > > > > > On Thu, 2 Mar 2017 23:25:06 +0530 > > > "Naveen N. Rao"

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On 2017/03/04 01:34PM, Masami Hiramatsu wrote: > On Sat, 4 Mar 2017 11:35:51 +0900 > Masami Hiramatsu wrote: > > > On Sat, 4 Mar 2017 09:49:11 +0900 > > Masami Hiramatsu wrote: > > > > > On Thu, 2 Mar 2017 23:25:06 +0530 > > > "Naveen N. Rao" wrote: > > > > > > > We indicate support for

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On 2017/03/04 09:49AM, Masami Hiramatsu wrote: > On Thu, 2 Mar 2017 23:25:06 +0530 > "Naveen N. Rao" wrote: > > > We indicate support for accepting sym+offset with kretprobes through a > > line in ftrace README. Parse the same to identify support and choose the

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On 2017/03/04 09:49AM, Masami Hiramatsu wrote: > On Thu, 2 Mar 2017 23:25:06 +0530 > "Naveen N. Rao" wrote: > > > We indicate support for accepting sym+offset with kretprobes through a > > line in ftrace README. Parse the same to identify support and choose the > > appropriate format for

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Sat, 4 Mar 2017 11:35:51 +0900 Masami Hiramatsu wrote: > On Sat, 4 Mar 2017 09:49:11 +0900 > Masami Hiramatsu wrote: > > > On Thu, 2 Mar 2017 23:25:06 +0530 > > "Naveen N. Rao" wrote: > > > > > We indicate support

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Sat, 4 Mar 2017 11:35:51 +0900 Masami Hiramatsu wrote: > On Sat, 4 Mar 2017 09:49:11 +0900 > Masami Hiramatsu wrote: > > > On Thu, 2 Mar 2017 23:25:06 +0530 > > "Naveen N. Rao" wrote: > > > > > We indicate support for accepting sym+offset with kretprobes through a > > > line in ftrace

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Sat, 4 Mar 2017 09:49:11 +0900 Masami Hiramatsu wrote: > On Thu, 2 Mar 2017 23:25:06 +0530 > "Naveen N. Rao" wrote: > > > We indicate support for accepting sym+offset with kretprobes through a > > line in ftrace README. Parse the same

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Sat, 4 Mar 2017 09:49:11 +0900 Masami Hiramatsu wrote: > On Thu, 2 Mar 2017 23:25:06 +0530 > "Naveen N. Rao" wrote: > > > We indicate support for accepting sym+offset with kretprobes through a > > line in ftrace README. Parse the same to identify support and choose the > > appropriate

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Sat, 4 Mar 2017 11:35:51 +0900 Masami Hiramatsu wrote: > On Sat, 4 Mar 2017 09:49:11 +0900 > Masami Hiramatsu wrote: > > > On Thu, 2 Mar 2017 23:25:06 +0530 > > "Naveen N. Rao" wrote: > > > > > We indicate support

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Sat, 4 Mar 2017 11:35:51 +0900 Masami Hiramatsu wrote: > On Sat, 4 Mar 2017 09:49:11 +0900 > Masami Hiramatsu wrote: > > > On Thu, 2 Mar 2017 23:25:06 +0530 > > "Naveen N. Rao" wrote: > > > > > We indicate support for accepting sym+offset with kretprobes through a > > > line in ftrace

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Thu, 2 Mar 2017 23:25:06 +0530 "Naveen N. Rao" wrote: > We indicate support for accepting sym+offset with kretprobes through a > line in ftrace README. Parse the same to identify support and choose the > appropriate format for kprobe_events. Could you give

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

On Thu, 2 Mar 2017 23:25:06 +0530 "Naveen N. Rao" wrote: > We indicate support for accepting sym+offset with kretprobes through a > line in ftrace README. Parse the same to identify support and choose the > appropriate format for kprobe_events. Could you give us an example of this change here?

[PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

We indicate support for accepting sym+offset with kretprobes through a line in ftrace README. Parse the same to identify support and choose the appropriate format for kprobe_events. Signed-off-by: Naveen N. Rao --- tools/perf/util/probe-event.c | 12 +---

[PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it

We indicate support for accepting sym+offset with kretprobes through a line in ftrace README. Parse the same to identify support and choose the appropriate format for kprobe_events. Signed-off-by: Naveen N. Rao --- tools/perf/util/probe-event.c | 12 +--- tools/perf/util/probe-file.c |