On Tue, Jul 23, 2019 at 03:24:53PM -0700, Stephen Boyd wrote:
> Quoting Rob Herring (2019-07-23 12:30:48)
> > There's also some cases that the irq seems to be optional. They use
> > dev_info, but will now have an error level print. That's fine with me,
> > but some may complain...
> Yeah I
On Tue, Jul 23, 2019 at 11:16:23AM -0700, Stephen Boyd wrote:
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
Acked-by: Mark Brown
On Tue, Jul 23, 2019 at 11:16:23AM -0700, Stephen Boyd wrote:
> diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
> index 9b2232908b65..40e4e8e03428 100644
> --- a/sound/soc/sunxi/sun4i-i2s.c
> +++ b/sound/soc/sunxi/sun4i-i2s.c
> @@ -1088,7 +1088,6 @@ static int
Quoting Rob Herring (2019-07-23 12:30:48)
> On Tue, Jul 23, 2019 at 12:16 PM Stephen Boyd wrote:
> >
> > We don't need dev_err() messages when platform_get_irq() fails now that
> > platform_get_irq() prints an error message itself when something goes
> > wrong. Let's remove these prints with a
Quoting Andy Shevchenko (2019-07-23 11:31:54)
> On Tue, Jul 23, 2019 at 9:16 PM Stephen Boyd wrote:
> >
> > We don't need dev_err() messages when platform_get_irq() fails now that
> > platform_get_irq() prints an error message itself when something goes
> > wrong. Let's remove these prints with a
On Tue, Jul 23, 2019 at 12:16 PM Stephen Boyd wrote:
>
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
Nice. Would be nice to see
On Tue, Jul 23, 2019 at 9:16 PM Stephen Boyd wrote:
>
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
>
> //
> @@
> expression ret;
>
7 matches
Mail list logo