Re: [PATCH v4 2/4] Make all base functions switch depending on product ID

2014-07-14 Thread Antonio Ospite
On Sun, 13 Jul 2014 08:24:20 +0100 Jamie Lentin wrote: > Signed-off-by: Jamie Lentin The commit message could be improved, it's not obvious to me what "base functions" means here, I am thinking to something like the following:

Re: [PATCH v4 2/4] Make all base functions switch depending on product ID

2014-07-14 Thread Antonio Ospite
On Sun, 13 Jul 2014 08:24:20 +0100 Jamie Lentin j...@lentin.co.uk wrote: Signed-off-by: Jamie Lentin j...@lentin.co.uk The commit message could be improved, it's not obvious to me what base functions means here, I am thinking to something like the following:

[PATCH v4 2/4] Make all base functions switch depending on product ID

2014-07-13 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo.c | 45 ++--- 1 file changed, 38 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index 0320b96..d11e337 100644 --- a/drivers/hid/hid-lenovo.c +++

[PATCH v4 2/4] Make all base functions switch depending on product ID

2014-07-13 Thread Jamie Lentin
Signed-off-by: Jamie Lentin j...@lentin.co.uk --- drivers/hid/hid-lenovo.c | 45 ++--- 1 file changed, 38 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index 0320b96..d11e337 100644 ---