Re: [PATCH v4 2/4] can: kvaser_usb: Update error counters before exiting on OOM

2015-01-16 Thread Marc Kleine-Budde
On 01/12/2015 09:36 PM, Ahmed S. Darwish wrote: > On Mon, Jan 12, 2015 at 12:09:32PM +0100, Marc Kleine-Budde wrote: >> On 01/11/2015 09:15 PM, Ahmed S. Darwish wrote: >>> From: Ahmed S. Darwish >>> >>> Let the error counters be more accurate in case of Out of >>> Memory conditions. >> >> Please

Re: [PATCH v4 2/4] can: kvaser_usb: Update error counters before exiting on OOM

2015-01-16 Thread Marc Kleine-Budde
On 01/12/2015 09:36 PM, Ahmed S. Darwish wrote: On Mon, Jan 12, 2015 at 12:09:32PM +0100, Marc Kleine-Budde wrote: On 01/11/2015 09:15 PM, Ahmed S. Darwish wrote: From: Ahmed S. Darwish ahmed.darw...@valeo.com Let the error counters be more accurate in case of Out of Memory conditions.

Re: [PATCH v4 2/4] can: kvaser_usb: Update error counters before exiting on OOM

2015-01-12 Thread Ahmed S. Darwish
On Mon, Jan 12, 2015 at 12:09:32PM +0100, Marc Kleine-Budde wrote: > On 01/11/2015 09:15 PM, Ahmed S. Darwish wrote: > > From: Ahmed S. Darwish > > > > Let the error counters be more accurate in case of Out of > > Memory conditions. > > Please have a look at kvaser_usb_rx_error(), the whole

Re: [PATCH v4 2/4] can: kvaser_usb: Update error counters before exiting on OOM

2015-01-12 Thread Marc Kleine-Budde
On 01/11/2015 09:15 PM, Ahmed S. Darwish wrote: > From: Ahmed S. Darwish > > Let the error counters be more accurate in case of Out of > Memory conditions. Please have a look at kvaser_usb_rx_error(), the whole state handling is omitted in case of OOM. Marc -- Pengutronix e.K.

Re: [PATCH v4 2/4] can: kvaser_usb: Update error counters before exiting on OOM

2015-01-12 Thread Marc Kleine-Budde
On 01/11/2015 09:15 PM, Ahmed S. Darwish wrote: From: Ahmed S. Darwish ahmed.darw...@valeo.com Let the error counters be more accurate in case of Out of Memory conditions. Please have a look at kvaser_usb_rx_error(), the whole state handling is omitted in case of OOM. Marc -- Pengutronix

Re: [PATCH v4 2/4] can: kvaser_usb: Update error counters before exiting on OOM

2015-01-12 Thread Ahmed S. Darwish
On Mon, Jan 12, 2015 at 12:09:32PM +0100, Marc Kleine-Budde wrote: On 01/11/2015 09:15 PM, Ahmed S. Darwish wrote: From: Ahmed S. Darwish ahmed.darw...@valeo.com Let the error counters be more accurate in case of Out of Memory conditions. Please have a look at kvaser_usb_rx_error(),

[PATCH v4 2/4] can: kvaser_usb: Update error counters before exiting on OOM

2015-01-11 Thread Ahmed S. Darwish
From: Ahmed S. Darwish Let the error counters be more accurate in case of Out of Memory conditions. Suggested-by: Marc Kleine-Budde Signed-off-by: Ahmed S. Darwish --- drivers/net/can/usb/kvaser_usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v4 2/4] can: kvaser_usb: Update error counters before exiting on OOM

2015-01-11 Thread Ahmed S. Darwish
From: Ahmed S. Darwish ahmed.darw...@valeo.com Let the error counters be more accurate in case of Out of Memory conditions. Suggested-by: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Ahmed S. Darwish ahmed.darw...@valeo.com --- drivers/net/can/usb/kvaser_usb.c | 6 +++--- 1 file