Re: [PATCH v4 2/4] gpio: visconti: Add Toshiba Visconti GPIO support

2020-12-16 Thread Nobuhiro Iwamatsu
Hi, On Wed, Dec 16, 2020 at 09:36:17AM +, Marc Zyngier wrote: > On 2020-12-16 09:11, Nobuhiro Iwamatsu wrote: > > [...] > > > > > + for (i = 0; i < num_irq; i++) { > > > > + desc = irq_to_desc(priv->irq[i]); > > > > + desc->status_use_accessors |=

Re: [PATCH v4 2/4] gpio: visconti: Add Toshiba Visconti GPIO support

2020-12-16 Thread Marc Zyngier
On 2020-12-16 09:11, Nobuhiro Iwamatsu wrote: [...] > + for (i = 0; i < num_irq; i++) { > + desc = irq_to_desc(priv->irq[i]); > + desc->status_use_accessors |= IRQ_NOAUTOEN; > + if (devm_request_irq(dev, priv->irq[i], > +

Re: [PATCH v4 2/4] gpio: visconti: Add Toshiba Visconti GPIO support

2020-12-16 Thread Nobuhiro Iwamatsu
Hi, Thanks for your review. On Sat, Dec 12, 2020 at 12:20:47AM +0100, Linus Walleij wrote: > On Fri, Dec 11, 2020 at 1:43 AM Nobuhiro Iwamatsu > wrote: > > This iteration is looking really good, but we are not quite there yet, > because now that the driver looks so much better I can see that

Re: [PATCH v4 2/4] gpio: visconti: Add Toshiba Visconti GPIO support

2020-12-11 Thread Linus Walleij
On Fri, Dec 11, 2020 at 1:43 AM Nobuhiro Iwamatsu wrote: This iteration is looking really good, but we are not quite there yet, because now that the driver looks so much better I can see that it is a hierarchical interrupt controller. > Add the GPIO driver for Toshiba Visconti ARM SoCs. > >

[PATCH v4 2/4] gpio: visconti: Add Toshiba Visconti GPIO support

2020-12-10 Thread Nobuhiro Iwamatsu
Add the GPIO driver for Toshiba Visconti ARM SoCs. Signed-off-by: Nobuhiro Iwamatsu Reviewed-by: Punit Agrawal --- drivers/gpio/Kconfig | 9 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-visconti.c | 230 ++