Re: [PATCH v4 2/4] staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages

2018-08-23 Thread Nishad Kamdar
On Wed, Aug 22, 2018 at 12:13:42PM +0300, Dan Carpenter wrote: > On Wed, Aug 22, 2018 at 02:13:07PM +0530, Nishad Kamdar wrote: > > diff --git a/drivers/staging/mt7621-mmc/sd.c > > b/drivers/staging/mt7621-mmc/sd.c > > index 04d23cc7cd4a..6b2c72fc61f2 100644 > > ---

Re: [PATCH v4 2/4] staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages

2018-08-23 Thread Nishad Kamdar
On Wed, Aug 22, 2018 at 12:13:42PM +0300, Dan Carpenter wrote: > On Wed, Aug 22, 2018 at 02:13:07PM +0530, Nishad Kamdar wrote: > > diff --git a/drivers/staging/mt7621-mmc/sd.c > > b/drivers/staging/mt7621-mmc/sd.c > > index 04d23cc7cd4a..6b2c72fc61f2 100644 > > ---

Re: [PATCH v4 2/4] staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages

2018-08-22 Thread Nishad Kamdar
On Wed, Aug 22, 2018 at 12:13:42PM +0300, Dan Carpenter wrote: > On Wed, Aug 22, 2018 at 02:13:07PM +0530, Nishad Kamdar wrote: > > diff --git a/drivers/staging/mt7621-mmc/sd.c > > b/drivers/staging/mt7621-mmc/sd.c > > index 04d23cc7cd4a..6b2c72fc61f2 100644 > > ---

Re: [PATCH v4 2/4] staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages

2018-08-22 Thread Nishad Kamdar
On Wed, Aug 22, 2018 at 12:13:42PM +0300, Dan Carpenter wrote: > On Wed, Aug 22, 2018 at 02:13:07PM +0530, Nishad Kamdar wrote: > > diff --git a/drivers/staging/mt7621-mmc/sd.c > > b/drivers/staging/mt7621-mmc/sd.c > > index 04d23cc7cd4a..6b2c72fc61f2 100644 > > ---

Re: [PATCH v4 2/4] staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages

2018-08-22 Thread Dan Carpenter
On Wed, Aug 22, 2018 at 02:13:07PM +0530, Nishad Kamdar wrote: > diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c > index 04d23cc7cd4a..6b2c72fc61f2 100644 > --- a/drivers/staging/mt7621-mmc/sd.c > +++ b/drivers/staging/mt7621-mmc/sd.c > @@ -466,7 +466,8 @@ static

Re: [PATCH v4 2/4] staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages

2018-08-22 Thread Dan Carpenter
On Wed, Aug 22, 2018 at 02:13:07PM +0530, Nishad Kamdar wrote: > diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c > index 04d23cc7cd4a..6b2c72fc61f2 100644 > --- a/drivers/staging/mt7621-mmc/sd.c > +++ b/drivers/staging/mt7621-mmc/sd.c > @@ -466,7 +466,8 @@ static

[PATCH v4 2/4] staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages

2018-08-22 Thread Nishad Kamdar
Replace all usages of ERR_MSG with with dev_ without __func__ or __LINE__ or current->comm and current->pid. Remove the do {} while(0) loop for the single statement macro. Drop ERR_MSG from dbg.h. Issue found by checkpatch. Signed-off-by: Nishad Kamdar --- drivers/staging/mt7621-mmc/dbg.h | 6

[PATCH v4 2/4] staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages

2018-08-22 Thread Nishad Kamdar
Replace all usages of ERR_MSG with with dev_ without __func__ or __LINE__ or current->comm and current->pid. Remove the do {} while(0) loop for the single statement macro. Drop ERR_MSG from dbg.h. Issue found by checkpatch. Signed-off-by: Nishad Kamdar --- drivers/staging/mt7621-mmc/dbg.h | 6