Re: [PATCH v4 2/4] sysctl: Move some boundary constants form sysctl.c to sysctl_vals

2020-05-19 Thread Luis Chamberlain
On Wed, May 20, 2020 at 09:14:08AM +0800, Xiaoming Ni wrote: > On 2020/5/19 12:44, Tetsuo Handa wrote: > > On 2020/05/19 12:31, Xiaoming Ni wrote: > > > Some boundary (.extra1 .extra2) constants (E.g: neg_one two) in > > > sysctl.c are used in multiple features. Move these variables to > > > sysctl

Re: [PATCH v4 2/4] sysctl: Move some boundary constants form sysctl.c to sysctl_vals

2020-05-19 Thread Xiaoming Ni
On 2020/5/19 12:44, Tetsuo Handa wrote: On 2020/05/19 12:31, Xiaoming Ni wrote: Some boundary (.extra1 .extra2) constants (E.g: neg_one two) in sysctl.c are used in multiple features. Move these variables to sysctl_vals to avoid adding duplicate variables when cleaning up sysctls table. Signed-

Re: [PATCH v4 2/4] sysctl: Move some boundary constants form sysctl.c to sysctl_vals

2020-05-18 Thread Tetsuo Handa
On 2020/05/19 12:31, Xiaoming Ni wrote: > Some boundary (.extra1 .extra2) constants (E.g: neg_one two) in > sysctl.c are used in multiple features. Move these variables to > sysctl_vals to avoid adding duplicate variables when cleaning up > sysctls table. > > Signed-off-by: Xiaoming Ni > Reviewed

[PATCH v4 2/4] sysctl: Move some boundary constants form sysctl.c to sysctl_vals

2020-05-18 Thread Xiaoming Ni
Some boundary (.extra1 .extra2) constants (E.g: neg_one two) in sysctl.c are used in multiple features. Move these variables to sysctl_vals to avoid adding duplicate variables when cleaning up sysctls table. Signed-off-by: Xiaoming Ni Reviewed-by: Kees Cook --- fs/proc/proc_sysctl.c | 2 +- i