Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-16 Thread Ray Jui
On 1/16/2015 11:48 AM, Uwe Kleine-König wrote: > Hello, > > On Fri, Jan 16, 2015 at 11:24:09AM -0800, Ray Jui wrote: + i2c0: i2c@18008000 { + compatible = "brcm,iproc-i2c"; >>> in patch 2 you wrote the driver is for a family of SoCs, right? Then I'd >>> make this: >>> >>>

Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-16 Thread Uwe Kleine-König
Hello, On Fri, Jan 16, 2015 at 11:24:09AM -0800, Ray Jui wrote: > >> + i2c0: i2c@18008000 { > >> + compatible = "brcm,iproc-i2c"; > > in patch 2 you wrote the driver is for a family of SoCs, right? Then I'd > > make this: > > > > compatible = "brcm,$mysoc-iproc-i2c",

Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-16 Thread Ray Jui
On 1/15/2015 12:44 AM, Uwe Kleine-König wrote: > Hello, > > On Wed, Jan 14, 2015 at 02:23:33PM -0800, Ray Jui wrote: >> Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep >> them disabled there. Individual I2C devices can be enabled in board >> specific dts file when I2C slave

Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-16 Thread Ray Jui
On 1/15/2015 12:44 AM, Uwe Kleine-König wrote: Hello, On Wed, Jan 14, 2015 at 02:23:33PM -0800, Ray Jui wrote: Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep them disabled there. Individual I2C devices can be enabled in board specific dts file when I2C slave devices

Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-16 Thread Uwe Kleine-König
Hello, On Fri, Jan 16, 2015 at 11:24:09AM -0800, Ray Jui wrote: + i2c0: i2c@18008000 { + compatible = brcm,iproc-i2c; in patch 2 you wrote the driver is for a family of SoCs, right? Then I'd make this: compatible = brcm,$mysoc-iproc-i2c, brcm,iproc-i2c; Sorry could

Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-16 Thread Ray Jui
On 1/16/2015 11:48 AM, Uwe Kleine-König wrote: Hello, On Fri, Jan 16, 2015 at 11:24:09AM -0800, Ray Jui wrote: + i2c0: i2c@18008000 { + compatible = brcm,iproc-i2c; in patch 2 you wrote the driver is for a family of SoCs, right? Then I'd make this: compatible =

Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-15 Thread Uwe Kleine-König
Hello, On Wed, Jan 14, 2015 at 02:23:33PM -0800, Ray Jui wrote: > Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep > them disabled there. Individual I2C devices can be enabled in board > specific dts file when I2C slave devices are enabled in the future s/$/./ > >

Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-15 Thread Uwe Kleine-König
Hello, On Wed, Jan 14, 2015 at 02:23:33PM -0800, Ray Jui wrote: Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep them disabled there. Individual I2C devices can be enabled in board specific dts file when I2C slave devices are enabled in the future s/$/./ Signed-off-by:

[PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-14 Thread Ray Jui
Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep them disabled there. Individual I2C devices can be enabled in board specific dts file when I2C slave devices are enabled in the future Signed-off-by: Ray Jui Reviewed-by: Scott Branden --- arch/arm/boot/dts/bcm-cygnus.dtsi |

[PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-14 Thread Ray Jui
Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep them disabled there. Individual I2C devices can be enabled in board specific dts file when I2C slave devices are enabled in the future Signed-off-by: Ray Jui r...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com ---