Re: [PATCH v4 3/3] i2c: at91: added slave mode support

2019-02-19 Thread Ludovic Desroches
Hi, On Fri, Feb 15, 2019 at 10:18:47AM +0100, Wolfram Sang wrote: > On Tue, Jan 15, 2019 at 11:43:51PM +0100, Wolfram Sang wrote: > > > > > All errors (new ones prefixed by >>): > > > > > > >> ERROR: "at91_init_twi_bus_slave" [drivers/i2c/busses/i2c-at91.ko] > > > >> undefined! > > > >> ERROR:

Re: [PATCH v4 3/3] i2c: at91: added slave mode support

2019-02-15 Thread Wolfram Sang
On Tue, Jan 15, 2019 at 11:43:51PM +0100, Wolfram Sang wrote: > > > All errors (new ones prefixed by >>): > > > > >> ERROR: "at91_init_twi_bus_slave" [drivers/i2c/busses/i2c-at91.ko] > > >> undefined! > > >> ERROR: "at91_twi_probe_slave" [drivers/i2c/busses/i2c-at91.ko] undefined! > > That

Re: [PATCH v4 3/3] i2c: at91: added slave mode support

2019-01-15 Thread Wolfram Sang
> All errors (new ones prefixed by >>): > > >> ERROR: "at91_init_twi_bus_slave" [drivers/i2c/busses/i2c-at91.ko] > >> undefined! > >> ERROR: "at91_twi_probe_slave" [drivers/i2c/busses/i2c-at91.ko] undefined! That needs to be fixed. Rest looks good to me! signature.asc Description: PGP

Re: [PATCH v4 3/3] i2c: at91: added slave mode support

2019-01-04 Thread kbuild test robot
Hi Juergen, Thank you for the patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.20 next-20190103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4 3/3] i2c: at91: added slave mode support

2019-01-01 Thread Wolfram Sang
> Perhaps, you can use SPDX instead of boiler plate license text in the files? I think we can do this incrementally. signature.asc Description: PGP signature

Re: [PATCH v4 3/3] i2c: at91: added slave mode support

2018-12-31 Thread Andy Shevchenko
> Slave mode driver is based on the concept of i2c-designware driver. > +/* > + * i2c slave support for Atmel's AT91 Two-Wire Interface (TWI) > + * > + * Copyright (C) 2017 Juergen Fitschen > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the

[PATCH v4 3/3] i2c: at91: added slave mode support

2018-12-27 Thread Ludovic Desroches
From: Juergen Fitschen Slave mode driver is based on the concept of i2c-designware driver. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: rework Kconfig] Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/Kconfig | 13 +++ drivers/i2c/busses/Makefile