Re: [PATCH v4 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs

2019-03-13 Thread Greg Kroah-Hartman
On Wed, Mar 13, 2019 at 05:36:10PM +0100, Wolfram Sang wrote: > Hi Greg, > > > > I was wondering if you think the below ABI addition looks sane to you? > > I am not the i2c maintainer :) > > Peter is the i2c-mux maintainer, so I trust him very much on the I2C > side of things. We just wondered

Re: [PATCH v4 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs

2019-03-13 Thread Wolfram Sang
Hi Greg, > > I was wondering if you think the below ABI addition looks sane to you? > I am not the i2c maintainer :) Peter is the i2c-mux maintainer, so I trust him very much on the I2C side of things. We just wondered if you'd notice a general flaw when exposing such an interface to userspace.

Re: [PATCH v4 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs

2019-03-13 Thread Greg Kroah-Hartman
On Wed, Mar 13, 2019 at 07:04:06AM +, Peter Rosin wrote: > Hi Greg, > > I was wondering if you think the below ABI addition looks sane to you? I am not the i2c maintainer :) > Or, should I ask someone else for a tag? It's the middle of the merge window. None of us can do much other than

Re: [PATCH v4 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs

2019-03-13 Thread Peter Rosin
Hi Greg, I was wondering if you think the below ABI addition looks sane to you? Or, should I ask someone else for a tag? Cheers, Peter On 2019-02-28 12:43, Robert Shearman wrote: > From: Robert Shearman > > The behaviour, by default, to not deselect after each transfer is > unsafe when there

[PATCH v4 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs

2019-02-28 Thread Robert Shearman
From: Robert Shearman The behaviour, by default, to not deselect after each transfer is unsafe when there is a device with an address that conflicts with another device on another mux on the same parent bus, and it may not be convenient to use devicetree to set the deselect mux, e.g. when