Re: [PATCH v4 3/3] livepatch: Remove duplicate warning about missing reliable stacktrace support

2019-06-12 Thread Kamalesh Babulal
On Tue, Jun 11, 2019 at 04:13:20PM +0200, Miroslav Benes wrote: > From: Petr Mladek > > WARN_ON_ONCE() could not be called safely under rq lock because > of console deadlock issues. Moreover WARN_ON_ONCE() is superfluous in > klp_check_stack(), because stack_trace_save_tsk_reliable() cannot

[PATCH v4 3/3] livepatch: Remove duplicate warning about missing reliable stacktrace support

2019-06-11 Thread Miroslav Benes
From: Petr Mladek WARN_ON_ONCE() could not be called safely under rq lock because of console deadlock issues. Moreover WARN_ON_ONCE() is superfluous in klp_check_stack(), because stack_trace_save_tsk_reliable() cannot return -ENOSYS thanks to klp_have_reliable_stack() check in