Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets

2016-09-02 Thread Masami Hiramatsu
2016-09-02 21:41 GMT+09:00 Binoy Jayan : > On 30 August 2016 at 16:20, Masami Hiramatsu > wrote: >> Hi Binoy, >>> >>> +static inline void trace_latency_hrtimer_mark_ts(struct hrtimer *timer, >>> +struct hrtimer_clock_base >>> *new_base, >>> +

Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets

2016-09-02 Thread Binoy Jayan
On 30 August 2016 at 16:20, Masami Hiramatsu wrote: > Hi Binoy, >> >> +static inline void trace_latency_hrtimer_mark_ts(struct hrtimer *timer, >> +struct hrtimer_clock_base *new_base, >> +ktime_t tim) >> +{ >> +#if def

Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets

2016-08-31 Thread Steven Rostedt
On Wed, 31 Aug 2016 17:04:54 +0530 Binoy Jayan wrote: > On 30 August 2016 at 19:45, Steven Rostedt wrote: > > On Tue, 30 Aug 2016 15:58:44 +0530 > > Binoy Jayan wrote: > > > >> + > >> + TP_STRUCT__entry( > >> + __field(long long, toffset) > >> + __array(char,

Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets

2016-08-31 Thread Binoy Jayan
On 30 August 2016 at 19:45, Steven Rostedt wrote: > On Tue, 30 Aug 2016 15:58:44 +0530 > Binoy Jayan wrote: > >> + >> + TP_STRUCT__entry( >> + __field(long long, toffset) >> + __array(char, ccomm, TASK_COMM_LEN) > > Can curr be different than current? I

Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets

2016-08-30 Thread Steven Rostedt
On Tue, 30 Aug 2016 15:58:44 +0530 Binoy Jayan wrote: > +TRACE_EVENT(latency_hrtimer_interrupt, > + > + TP_PROTO(long long toffset, struct task_struct *curr, > + struct task_struct *task), > + > + TP_ARGS(toffset, curr, task), > + > + TP_STRUCT__entry( > + __fi

Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets

2016-08-30 Thread Masami Hiramatsu
Hi Binoy, 2016-08-30 19:28 GMT+09:00 Binoy Jayan : > Latencies of missed timer offsets. Generate a histogram of missed > timer offsets in microseconds. This will be a based along with irq > and preemption latencies to calculate the effective process wakeup > latencies. > > The following filter(s)

[PATCH v4 3/3] tracing: Histogram for missed timer offsets

2016-08-30 Thread Binoy Jayan
Latencies of missed timer offsets. Generate a histogram of missed timer offsets in microseconds. This will be a based along with irq and preemption latencies to calculate the effective process wakeup latencies. The following filter(s) may be used 'hist:key=common_pid.execname' 'hist:key=common_pi