Re: [PATCH v4 3/4] mm/pageblock: work around multiple arch's cmpxchg support issue

2020-09-09 Thread Christoph Hellwig
On Thu, Sep 03, 2020 at 03:01:22PM +0800, Alex Shi wrote: > Armv6, sh2, sparc32 and xtensa can not do cmpxchg1, so we have to use > cmpxchg4 on it. > > Here we mark above 4 arch's NO_CMPXCHG_BYTE, and would add more if we > found. > > This is the first usages of cmpxchg flase sharing change.

Re: [PATCH v4 3/4] mm/pageblock: work around multiple arch's cmpxchg support issue

2020-09-03 Thread Alex Shi
在 2020/9/3 下午3:29, Max Filippov 写道: >> diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig >> index e997e0119c02..862b008ab09e 100644 >> --- a/arch/xtensa/Kconfig >> +++ b/arch/xtensa/Kconfig >> @@ -42,6 +42,7 @@ config XTENSA >> select MODULES_USE_ELF_RELA >> select

Re: [PATCH v4 3/4] mm/pageblock: work around multiple arch's cmpxchg support issue

2020-09-03 Thread Max Filippov
On Thu, Sep 3, 2020 at 12:01 AM Alex Shi wrote: > > Armv6, sh2, sparc32 and xtensa can not do cmpxchg1, so we have to use > cmpxchg4 on it. [...] > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig> index > e00d94b16658..03a6c7fd999d 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@

[PATCH v4 3/4] mm/pageblock: work around multiple arch's cmpxchg support issue

2020-09-03 Thread Alex Shi
Armv6, sh2, sparc32 and xtensa can not do cmpxchg1, so we have to use cmpxchg4 on it. Here we mark above 4 arch's NO_CMPXCHG_BYTE, and would add more if we found. This is the first usages of cmpxchg flase sharing change. We'd better check more cmpxchg usages in current kernel... Reported-by: