Re: [PATCH v4 3/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2021-01-08 Thread Doug Anderson
Hi, On Mon, Dec 21, 2020 at 8:01 AM Maulik Shah wrote: > > Hi Doug, > > On 12/12/2020 3:45 AM, Douglas Anderson wrote: > > In Linux, if a driver does disable_irq() and later does enable_irq() > > on its interrupt, I believe it's expecting these properties: > > * If an interrupt was pending when t

Re: [PATCH v4 3/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2020-12-21 Thread Maulik Shah
Hi Doug, On 12/12/2020 3:45 AM, Douglas Anderson wrote: In Linux, if a driver does disable_irq() and later does enable_irq() on its interrupt, I believe it's expecting these properties: * If an interrupt was pending when the driver disabled then it will still be pending after the driver re-en

Re: [PATCH v4 3/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2020-12-17 Thread Rajendra Nayak
On 12/12/2020 3:45 AM, Douglas Anderson wrote: In Linux, if a driver does disable_irq() and later does enable_irq() on its interrupt, I believe it's expecting these properties: * If an interrupt was pending when the driver disabled then it will still be pending after the driver re-enables. *

Re: [PATCH v4 3/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2020-12-16 Thread Stephen Boyd
Quoting Douglas Anderson (2020-12-11 14:15:37) > In Linux, if a driver does disable_irq() and later does enable_irq() > on its interrupt, I believe it's expecting these properties: > * If an interrupt was pending when the driver disabled then it will > still be pending after the driver re-enables

[PATCH v4 3/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2020-12-11 Thread Douglas Anderson
In Linux, if a driver does disable_irq() and later does enable_irq() on its interrupt, I believe it's expecting these properties: * If an interrupt was pending when the driver disabled then it will still be pending after the driver re-enables. * If an edge-triggered interrupt comes in while an in