Re: [PATCH v4 3/5] dt-bindings: phy: tegra: Add Tegra194 support

2019-10-17 Thread Thierry Reding
On Thu, Oct 17, 2019 at 03:48:52PM +0800, JC Kuo wrote: > Hi Thierry, Hi Rob, Hi Kishon, > Please let me know your thoughts of the below implementation. > > 1. Add a "bool disable_gen2" to "phy->attrs" structure. > 2. In _of_phy_get() of phy-core.c to add the follow to parse a generic >

Re: [PATCH v4 3/5] dt-bindings: phy: tegra: Add Tegra194 support

2019-10-17 Thread Thierry Reding
On Thu, Oct 17, 2019 at 03:48:52PM +0800, JC Kuo wrote: > Hi Thierry, Hi Rob, Hi Kishon, > Please let me know your thoughts of the below implementation. > > 1. Add a "bool disable_gen2" to "phy->attrs" structure. phy->attrs is pretty bus agnostic, so adding a USB-specific property doesn't sound

Re: [PATCH v4 3/5] dt-bindings: phy: tegra: Add Tegra194 support

2019-10-17 Thread JC Kuo
Hi Thierry, Hi Rob, Hi Kishon, Please let me know your thoughts of the below implementation. 1. Add a "bool disable_gen2" to "phy->attrs" structure. 2. In _of_phy_get() of phy-core.c to add the follow to parse a generic property. phy->attrs.disable_gen2 = of_property_read_bool(args.np,

Re: [PATCH v4 3/5] dt-bindings: phy: tegra: Add Tegra194 support

2019-10-14 Thread Rob Herring
On Mon, Oct 14, 2019 at 8:17 AM Thierry Reding wrote: > > On Wed, Oct 09, 2019 at 06:39:00PM -0500, Rob Herring wrote: > > On Wed, Oct 09, 2019 at 10:43:41AM +0800, JC Kuo wrote: > > > Extend the bindings to cover the set of features found in Tegra194. > > > Note that, technically, there are four

Re: [PATCH v4 3/5] dt-bindings: phy: tegra: Add Tegra194 support

2019-10-14 Thread Thierry Reding
On Wed, Oct 09, 2019 at 06:39:00PM -0500, Rob Herring wrote: > On Wed, Oct 09, 2019 at 10:43:41AM +0800, JC Kuo wrote: > > Extend the bindings to cover the set of features found in Tegra194. > > Note that, technically, there are four more supplies connected to the > > XUSB pad controller

Re: [PATCH v4 3/5] dt-bindings: phy: tegra: Add Tegra194 support

2019-10-09 Thread Rob Herring
On Wed, Oct 09, 2019 at 10:43:41AM +0800, JC Kuo wrote: > Extend the bindings to cover the set of features found in Tegra194. > Note that, technically, there are four more supplies connected to the > XUSB pad controller (DVDD_PEX, DVDD_PEX_PLL, HVDD_PEX and HVDD_PEX_PLL) > , but the power

[PATCH v4 3/5] dt-bindings: phy: tegra: Add Tegra194 support

2019-10-08 Thread JC Kuo
Extend the bindings to cover the set of features found in Tegra194. Note that, technically, there are four more supplies connected to the XUSB pad controller (DVDD_PEX, DVDD_PEX_PLL, HVDD_PEX and HVDD_PEX_PLL) , but the power sequencing requirements of Tegra194 require these to be under the