Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 18:27>, when Marc Kleine-Budde wrote: > On 10/28/20 10:40 PM, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The driver has be

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Andrew Lunn
> >> +static irqreturn_t ax88796c_interrupt(int irq, void *dev_instance) > >> +{ > >> + struct net_device *ndev = dev_instance; > >> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev); Do the assignment later. Andrew

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 01:31>, when Andrew Lunn wrote: > > Reverse christmass tree > >> + >> +static int ax88796c_process_isr(struct ax88796c_device *ax_local) >> +{ >> +u16 isr; >> +u8 done = 0; >> +struct net_device *ndev = ax_local->ndev; > > ... > >> +static irqreturn_t ax88796c_int

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Marc Kleine-Budde
On 10/28/20 10:40 PM, Łukasz Stelmach wrote: > ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > connected to a CPU with a 8/16-bit bus or with an SPI. This driver > supports SPI connection. > > The driver has been ported from the vendor kernel for ARTIK5[2] > boards. Several cha

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 01:31>, when Andrew Lunn wrote: >> +static void >> +ax88796c_get_regs(struct net_device *ndev, struct ethtool_regs *regs, void >> *_p) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> +u16 *p = _p; >> +int offset, i; > > You missed a reve

[PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-28 Thread Łukasz Stelmach
ASIX AX88796[1] is a versatile ethernet adapter chip, that can be connected to a CPU with a 8/16-bit bus or with an SPI. This driver supports SPI connection. The driver has been ported from the vendor kernel for ARTIK5[2] boards. Several changes were made to adapt it to the current kernel which in

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-28 Thread Andrew Lunn
> +static void > +ax88796c_get_regs(struct net_device *ndev, struct ethtool_regs *regs, void > *_p) > +{ > + struct ax88796c_device *ax_local = to_ax88796c_device(ndev); > + u16 *p = _p; > + int offset, i; You missed a reverse christmass tree fix here. > +static int comp; > +static i