Re: [PATCH v4 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-06-02 Thread Sumit Garg
On Wed, 3 Jun 2020 at 03:02, Doug Anderson wrote: > > Hi, > > On Fri, May 29, 2020 at 4:27 AM Sumit Garg wrote: > > > > In kgdb context, calling console handlers aren't safe due to locks used > > in those handlers which could in turn lead to a deadlock. Although, using > > oops_in_progress

Re: [PATCH v4 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-06-02 Thread Doug Anderson
Hi, On Fri, May 29, 2020 at 4:27 AM Sumit Garg wrote: > > In kgdb context, calling console handlers aren't safe due to locks used > in those handlers which could in turn lead to a deadlock. Although, using > oops_in_progress increases the chance to bypass locks in most console > handlers but it

Re: [PATCH v4 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-06-02 Thread Sumit Garg
On Tue, 2 Jun 2020 at 19:16, Daniel Thompson wrote: > > On Fri, May 29, 2020 at 04:56:47PM +0530, Sumit Garg wrote: > > In kgdb context, calling console handlers aren't safe due to locks used > > in those handlers which could in turn lead to a deadlock. Although, using > > oops_in_progress

Re: [PATCH v4 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-06-02 Thread Daniel Thompson
On Fri, May 29, 2020 at 04:56:47PM +0530, Sumit Garg wrote: > In kgdb context, calling console handlers aren't safe due to locks used > in those handlers which could in turn lead to a deadlock. Although, using > oops_in_progress increases the chance to bypass locks in most console > handlers but

Re: [PATCH v4 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-05-31 Thread Sumit Garg
On Sun, 31 May 2020 at 10:58, kbuild test robot wrote: > > Hi Sumit, > > I love your patch! Yet something to improve: > > [auto build test ERROR on tty/tty-testing] > [also build test ERROR on usb/usb-testing v5.7-rc7 next-20200529] > [cannot apply to kgdb/kgdb-next] > [if your patch is applied

Re: [PATCH v4 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-05-31 Thread kbuild test robot
Hi Sumit, I love your patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on usb/usb-testing v5.7-rc7 next-20200529] [cannot apply to kgdb/kgdb-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system.

[PATCH v4 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-05-29 Thread Sumit Garg
In kgdb context, calling console handlers aren't safe due to locks used in those handlers which could in turn lead to a deadlock. Although, using oops_in_progress increases the chance to bypass locks in most console handlers but it might not be sufficient enough in case a console uses more locks