Re: [PATCH v4 4/4] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-21 Thread Christoph Hellwig
On Wed, Aug 07, 2019 at 05:51:22PM +1000, Benjamin Herrenschmidt wrote: > Another issue with the Apple T2 based 2018 controllers seem to be > that they blow up (and shut the machine down) if there's a tag > collision between the IO queue and the Admin queue. > > My suspicion is that they use our

[PATCH v4 4/4] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-07 Thread Benjamin Herrenschmidt
Another issue with the Apple T2 based 2018 controllers seem to be that they blow up (and shut the machine down) if there's a tag collision between the IO queue and the Admin queue. My suspicion is that they use our tags for their internal tracking and don't mix them with the queue id. They also