Re: [PATCH v4 4/5] regulator: add regulator driver of hi655x pmic

On 2016/1/5 23:44, Mark Brown wrote: > On Mon, Jan 04, 2016 at 08:27:51PM +0800, Chen Feng wrote: > >> +/*LDO 2 & LDO 14*/ > > Please use the normal kernel coding style for comments, I'm surprised > checkpatch didn't warn you about this. > ok,thanks! >> +static const unsigned int

Re: [PATCH v4 4/5] regulator: add regulator driver of hi655x pmic

On 2016/1/5 23:44, Mark Brown wrote: > On Mon, Jan 04, 2016 at 08:27:51PM +0800, Chen Feng wrote: > >> +/*LDO 2 & LDO 14*/ > > Please use the normal kernel coding style for comments, I'm surprised > checkpatch didn't warn you about this. > ok,thanks! >> +static const unsigned int

Re: [PATCH v4 4/5] regulator: add regulator driver of hi655x pmic

On Mon, Jan 04, 2016 at 08:27:51PM +0800, Chen Feng wrote: > +/*LDO 2 & LDO 14*/ Please use the normal kernel coding style for comments, I'm surprised checkpatch didn't warn you about this. > +static const unsigned int ldo2_voltages[] = { > + 250, 260, 270, 280, > +

Re: [PATCH v4 4/5] regulator: add regulator driver of hi655x pmic

On Mon, Jan 04, 2016 at 08:27:51PM +0800, Chen Feng wrote: > +/*LDO 2 & LDO 14*/ Please use the normal kernel coding style for comments, I'm surprised checkpatch didn't warn you about this. > +static const unsigned int ldo2_voltages[] = { > + 250, 260, 270, 280, > +

[PATCH v4 4/5] regulator: add regulator driver of hi655x pmic

Add regulator support for hi655x pmic Signed-off-by: Chen Feng Signed-off-by: Fei Wang Signed-off-by: Xinwei Kong --- drivers/regulator/Kconfig| 8 ++ drivers/regulator/Makefile | 1 + drivers/regulator/hi655x-regulator.c | 232 +++ 3

[PATCH v4 4/5] regulator: add regulator driver of hi655x pmic

Add regulator support for hi655x pmic Signed-off-by: Chen Feng Signed-off-by: Fei Wang Signed-off-by: Xinwei Kong --- drivers/regulator/Kconfig| 8 ++ drivers/regulator/Makefile | 1 +