Re: [PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-29 Thread Maarten Lankhorst
Op 26-02-16 om 19:31 schreef Gustavo Padovan: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires > flags arises. > > v2: check if flags are

Re: [PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-29 Thread Maarten Lankhorst
Op 26-02-16 om 19:31 schreef Gustavo Padovan: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires > flags arises. > > v2: check if flags are valid (zero, in this case) > >

Re: [PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-28 Thread Emil Velikov
On 27 February 2016 at 15:27, Gustavo Padovan wrote: > Hi Emil, > > 2016-02-27 Emil Velikov : > >> Hi Gustavo, >> >> On 26 February 2016 at 18:31, Gustavo Padovan wrote: >> > From: Gustavo Padovan

Re: [PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-28 Thread Emil Velikov
On 27 February 2016 at 15:27, Gustavo Padovan wrote: > Hi Emil, > > 2016-02-27 Emil Velikov : > >> Hi Gustavo, >> >> On 26 February 2016 at 18:31, Gustavo Padovan wrote: >> > From: Gustavo Padovan >> > >> > Play safe and add flags member to all structs. So we don't need to >> > break API or

Re: [PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-27 Thread Gustavo Padovan
Hi Emil, 2016-02-27 Emil Velikov : > Hi Gustavo, > > On 26 February 2016 at 18:31, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Play safe and add flags member to all structs. So we don't need to > >

Re: [PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-27 Thread Gustavo Padovan
Hi Emil, 2016-02-27 Emil Velikov : > Hi Gustavo, > > On 26 February 2016 at 18:31, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Play safe and add flags member to all structs. So we don't need to > > break API or create new IOCTL in the future if new features that requires > >

Re: [PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-26 Thread Emil Velikov
Hi Gustavo, On 26 February 2016 at 18:31, Gustavo Padovan wrote: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires >

Re: [PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-26 Thread Emil Velikov
Hi Gustavo, On 26 February 2016 at 18:31, Gustavo Padovan wrote: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires > flags arises. > > v2: check if flags are valid (zero, in

[PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-26 Thread Gustavo Padovan
From: Gustavo Padovan Play safe and add flags member to all structs. So we don't need to break API or create new IOCTL in the future if new features that requires flags arises. v2: check if flags are valid (zero, in this case) Signed-off-by: Gustavo Padovan

[PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-26 Thread Gustavo Padovan
From: Gustavo Padovan Play safe and add flags member to all structs. So we don't need to break API or create new IOCTL in the future if new features that requires flags arises. v2: check if flags are valid (zero, in this case) Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c