Re: [PATCH v4 5/7] mm: rework non-root kmem_cache lifecycle management

2019-05-21 Thread Waiman Long
On 5/21/19 3:23 PM, Roman Gushchin wrote: > On Tue, May 21, 2019 at 02:39:50PM -0400, Waiman Long wrote: >> On 5/14/19 8:06 PM, Shakeel Butt wrote: @@ -2651,20 +2652,35 @@ struct kmem_cache *memcg_kmem_get_cache(struct kmem_cache *cachep) struct mem_cgroup *memcg;

Re: [PATCH v4 5/7] mm: rework non-root kmem_cache lifecycle management

2019-05-21 Thread Roman Gushchin
On Tue, May 21, 2019 at 02:39:50PM -0400, Waiman Long wrote: > On 5/14/19 8:06 PM, Shakeel Butt wrote: > >> @@ -2651,20 +2652,35 @@ struct kmem_cache *memcg_kmem_get_cache(struct > >> kmem_cache *cachep) > >> struct mem_cgroup *memcg; > >> struct kmem_cache *memcg_cachep; > >>

Re: [PATCH v4 5/7] mm: rework non-root kmem_cache lifecycle management

2019-05-20 Thread Roman Gushchin
On Mon, May 20, 2019 at 10:54:24AM -0400, Waiman Long wrote: > On 5/14/19 8:06 PM, Shakeel Butt wrote: > > diff --git a/mm/slab_common.c b/mm/slab_common.c > > index 4e5b4292a763..1ee967b4805e 100644 > > --- a/mm/slab_common.c > > +++ b/mm/slab_common.c > > @@ -45,6 +45,8 @@ static void

Re: [PATCH v4 5/7] mm: rework non-root kmem_cache lifecycle management

2019-05-20 Thread Waiman Long
On 5/14/19 8:06 PM, Shakeel Butt wrote: > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 4e5b4292a763..1ee967b4805e 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -45,6 +45,8 @@ static void slab_caches_to_rcu_destroy_workfn(struct > work_struct *work); > static

Re: [PATCH v4 5/7] mm: rework non-root kmem_cache lifecycle management

2019-05-15 Thread Shakeel Butt
From: Christopher Lameter Date: Wed, May 15, 2019 at 7:00 AM To: Roman Gushchin Cc: Andrew Morton, Shakeel Butt, , , , Johannes Weiner, Michal Hocko, Rik van Riel, Vladimir Davydov, > On Tue, 14 May 2019, Roman Gushchin wrote: > > > To make this possible we need to introduce a new percpu

Re: [PATCH v4 5/7] mm: rework non-root kmem_cache lifecycle management

2019-05-15 Thread Christopher Lameter
On Tue, 14 May 2019, Roman Gushchin wrote: > To make this possible we need to introduce a new percpu refcounter > for non-root kmem_caches. The counter is initialized to the percpu > mode, and is switched to atomic mode after deactivation, so we never > shutdown an active cache. The counter is

Re: [PATCH v4 5/7] mm: rework non-root kmem_cache lifecycle management

2019-05-14 Thread Shakeel Butt
From: Roman Gushchin Date: Tue, May 14, 2019 at 2:55 PM To: Andrew Morton, Shakeel Butt Cc: , , , Johannes Weiner, Michal Hocko, Rik van Riel, Christoph Lameter, Vladimir Davydov, , Roman Gushchin > This commit makes several important changes in the lifecycle > of a non-root kmem_cache, which